-
Notifications
You must be signed in to change notification settings - Fork 305
Partition muzzle tasks with the same method as build and tests #9077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 9 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~1601be4b47, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.001 s) : 0, 1001426
Total [baseline] (10.697 s) : 0, 10697424
Agent [candidate] (994.603 ms) : 0, 994603
Total [candidate] (10.629 s) : 0, 10628647
section appsec
Agent [baseline] (1.182 s) : 0, 1181979
Total [baseline] (10.786 s) : 0, 10785897
Agent [candidate] (1.183 s) : 0, 1182843
Total [candidate] (10.734 s) : 0, 10734375
section iast
Agent [baseline] (1.128 s) : 0, 1127971
Total [baseline] (10.815 s) : 0, 10815317
Agent [candidate] (1.132 s) : 0, 1131522
Total [candidate] (10.814 s) : 0, 10813556
section profiling
Agent [baseline] (1.244 s) : 0, 1243945
Total [baseline] (10.912 s) : 0, 10912428
Agent [candidate] (1.245 s) : 0, 1244738
Total [candidate] (10.985 s) : 0, 10984587
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~1601be4b47, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.172 ms) : 0, 692172
BytebuddyAgent [candidate] (687.017 ms) : 0, 687017
GlobalTracer [baseline] (242.795 ms) : 0, 242795
GlobalTracer [candidate] (241.611 ms) : 0, 241611
AppSec [baseline] (30.569 ms) : 0, 30569
AppSec [candidate] (30.41 ms) : 0, 30410
Debugger [baseline] (6.06 ms) : 0, 6060
Debugger [candidate] (6.034 ms) : 0, 6034
Remote Config [baseline] (678.684 µs) : 0, 679
Remote Config [candidate] (678.212 µs) : 0, 678
Telemetry [baseline] (8.246 ms) : 0, 8246
Telemetry [candidate] (8.177 ms) : 0, 8177
section appsec
BytebuddyAgent [baseline] (715.089 ms) : 0, 715089
BytebuddyAgent [candidate] (716.13 ms) : 0, 716130
GlobalTracer [baseline] (237.135 ms) : 0, 237135
GlobalTracer [candidate] (237.135 ms) : 0, 237135
IAST [baseline] (22.249 ms) : 0, 22249
IAST [candidate] (22.252 ms) : 0, 22252
AppSec [baseline] (171.961 ms) : 0, 171961
AppSec [candidate] (171.779 ms) : 0, 171779
Debugger [baseline] (5.862 ms) : 0, 5862
Debugger [candidate] (5.849 ms) : 0, 5849
Remote Config [baseline] (636.707 µs) : 0, 637
Remote Config [candidate] (609.151 µs) : 0, 609
Telemetry [baseline] (8.201 ms) : 0, 8201
Telemetry [candidate] (8.251 ms) : 0, 8251
section iast
BytebuddyAgent [baseline] (805.831 ms) : 0, 805831
BytebuddyAgent [candidate] (808.008 ms) : 0, 808008
GlobalTracer [baseline] (232.106 ms) : 0, 232106
GlobalTracer [candidate] (233.024 ms) : 0, 233024
IAST [baseline] (27.698 ms) : 0, 27698
IAST [candidate] (28.615 ms) : 0, 28615
AppSec [baseline] (27.385 ms) : 0, 27385
AppSec [candidate] (26.833 ms) : 0, 26833
Debugger [baseline] (5.811 ms) : 0, 5811
Debugger [candidate] (5.823 ms) : 0, 5823
Remote Config [baseline] (583.376 µs) : 0, 583
Remote Config [candidate] (572.53 µs) : 0, 573
Telemetry [baseline] (7.841 ms) : 0, 7841
Telemetry [candidate] (7.941 ms) : 0, 7941
section profiling
BytebuddyAgent [baseline] (678.065 ms) : 0, 678065
BytebuddyAgent [candidate] (678.577 ms) : 0, 678577
GlobalTracer [baseline] (360.399 ms) : 0, 360399
GlobalTracer [candidate] (361.471 ms) : 0, 361471
AppSec [baseline] (32.225 ms) : 0, 32225
AppSec [candidate] (34.518 ms) : 0, 34518
Debugger [baseline] (10.673 ms) : 0, 10673
Debugger [candidate] (9.124 ms) : 0, 9124
Remote Config [baseline] (1.391 ms) : 0, 1391
Remote Config [candidate] (670.463 µs) : 0, 670
Telemetry [baseline] (8.772 ms) : 0, 8772
Telemetry [candidate] (8.791 ms) : 0, 8791
ProfilingAgent [baseline] (103.917 ms) : 0, 103917
ProfilingAgent [candidate] (102.992 ms) : 0, 102992
Profiling [baseline] (103.941 ms) : 0, 103941
Profiling [candidate] (103.017 ms) : 0, 103017
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~1601be4b47, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.001 s) : 0, 1001359
Total [baseline] (8.536 s) : 0, 8536263
Agent [candidate] (995.791 ms) : 0, 995791
Total [candidate] (8.546 s) : 0, 8545525
section iast
Agent [baseline] (1.128 s) : 0, 1128491
Total [baseline] (9.291 s) : 0, 9290885
Agent [candidate] (1.133 s) : 0, 1133371
Total [candidate] (9.245 s) : 0, 9245176
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~1601be4b47, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (692.043 ms) : 0, 692043
BytebuddyAgent [candidate] (687.817 ms) : 0, 687817
GlobalTracer [baseline] (242.89 ms) : 0, 242890
GlobalTracer [candidate] (241.951 ms) : 0, 241951
AppSec [baseline] (30.633 ms) : 0, 30633
AppSec [candidate] (30.405 ms) : 0, 30405
Debugger [baseline] (6.058 ms) : 0, 6058
Debugger [candidate] (5.999 ms) : 0, 5999
Remote Config [baseline] (677.51 µs) : 0, 678
Remote Config [candidate] (674.669 µs) : 0, 675
Telemetry [baseline] (8.228 ms) : 0, 8228
Telemetry [candidate] (8.23 ms) : 0, 8230
section iast
BytebuddyAgent [baseline] (805.506 ms) : 0, 805506
BytebuddyAgent [candidate] (808.927 ms) : 0, 808927
GlobalTracer [baseline] (232.071 ms) : 0, 232071
GlobalTracer [candidate] (233.58 ms) : 0, 233580
IAST [baseline] (28.745 ms) : 0, 28745
IAST [candidate] (28.604 ms) : 0, 28604
AppSec [baseline] (27.001 ms) : 0, 27001
AppSec [candidate] (27.116 ms) : 0, 27116
Debugger [baseline] (5.874 ms) : 0, 5874
Debugger [candidate] (5.844 ms) : 0, 5844
Remote Config [baseline] (585.439 µs) : 0, 585
Remote Config [candidate] (580.634 µs) : 0, 581
Telemetry [baseline] (8.056 ms) : 0, 8056
Telemetry [candidate] (8.02 ms) : 0, 8020
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~1601be4b47, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section baseline
no_agent (36.856 ms) : 36546, 37166
. : milestone, 36856,
appsec (47.964 ms) : 47525, 48403
. : milestone, 47964,
code_origins (45.479 ms) : 45085, 45873
. : milestone, 45479,
iast (45.016 ms) : 44626, 45407
. : milestone, 45016,
profiling (48.753 ms) : 48284, 49222
. : milestone, 48753,
tracing (45.337 ms) : 44964, 45710
. : milestone, 45337,
section candidate
no_agent (37.2 ms) : 36899, 37502
. : milestone, 37200,
appsec (47.681 ms) : 47271, 48091
. : milestone, 47681,
code_origins (46.336 ms) : 45929, 46743
. : milestone, 46336,
iast (44.405 ms) : 44002, 44807
. : milestone, 44405,
profiling (50.6 ms) : 50138, 51062
. : milestone, 50600,
tracing (43.267 ms) : 42895, 43639
. : milestone, 43267,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.51.0-SNAPSHOT~1601be4b47, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section baseline
no_agent (4.401 ms) : 4351, 4450
. : milestone, 4401,
iast (9.317 ms) : 9166, 9469
. : milestone, 9317,
iast_FULL (14.258 ms) : 13971, 14544
. : milestone, 14258,
iast_GLOBAL (10.08 ms) : 9906, 10253
. : milestone, 10080,
profiling (9.151 ms) : 8997, 9306
. : milestone, 9151,
tracing (8.196 ms) : 8068, 8323
. : milestone, 8196,
section candidate
no_agent (4.486 ms) : 4433, 4538
. : milestone, 4486,
iast (9.09 ms) : 8936, 9244
. : milestone, 9090,
iast_FULL (13.724 ms) : 13448, 14000
. : milestone, 13724,
iast_GLOBAL (10.271 ms) : 10092, 10450
. : milestone, 10271,
profiling (8.758 ms) : 8611, 8904
. : milestone, 8758,
tracing (7.637 ms) : 7530, 7743
. : milestone, 7637,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~1601be4b47, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section baseline
no_agent (1.473 ms) : 1461, 1484
. : milestone, 1473,
appsec (2.394 ms) : 2345, 2443
. : milestone, 2394,
iast (2.177 ms) : 2115, 2238
. : milestone, 2177,
iast_GLOBAL (2.227 ms) : 2165, 2289
. : milestone, 2227,
profiling (2.027 ms) : 1977, 2076
. : milestone, 2027,
tracing (1.998 ms) : 1950, 2046
. : milestone, 1998,
section candidate
no_agent (1.475 ms) : 1463, 1486
. : milestone, 1475,
appsec (2.396 ms) : 2347, 2445
. : milestone, 2396,
iast (2.185 ms) : 2123, 2247
. : milestone, 2185,
iast_GLOBAL (2.232 ms) : 2170, 2294
. : milestone, 2232,
profiling (2.05 ms) : 1999, 2101
. : milestone, 2050,
tracing (2.017 ms) : 1969, 2066
. : milestone, 2017,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~1601be4b47, baseline=1.51.0-SNAPSHOT~5353d512d0
dateFormat X
axisFormat %s
section baseline
no_agent (15.438 s) : 15438000, 15438000
. : milestone, 15438000,
appsec (14.982 s) : 14982000, 14982000
. : milestone, 14982000,
iast (18.638 s) : 18638000, 18638000
. : milestone, 18638000,
iast_GLOBAL (17.842 s) : 17842000, 17842000
. : milestone, 17842000,
profiling (15.959 s) : 15959000, 15959000
. : milestone, 15959000,
tracing (14.784 s) : 14784000, 14784000
. : milestone, 14784000,
section candidate
no_agent (15.601 s) : 15601000, 15601000
. : milestone, 15601000,
appsec (15.08 s) : 15080000, 15080000
. : milestone, 15080000,
iast (18.403 s) : 18403000, 18403000
. : milestone, 18403000,
iast_GLOBAL (18.055 s) : 18055000, 18055000
. : milestone, 18055000,
profiling (15.386 s) : 15386000, 15386000
. : milestone, 15386000,
tracing (14.648 s) : 14648000, 14648000
. : milestone, 14648000,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, is there any downside to the build and test partitioning implementation?
@PerfectSlayer In theory yes: the approach used before ensured there were the same number of modules at each partition. While after the PR, it's based on a modulo of the gradle module path's hash code. So each partition might have different sizes. In practice, the precision of the former method is an illusion, since not every module takes the same time to process. |
For reference, the partitioning code in question: dd-trace-java/gradle/ci_jobs.gradle Lines 8 to 19 in 8a096fb
|
What Does This Do
writeMuzzleTasksToFile
and a way to partition tasks externally in the CI config, just use the same partitioning scheme we use for build and test tasks. It's also a simpler setup../gradlew :runMuzzle -PtaskPartitionCount=$NORMALIZED_NODE_TOTAL -PtaskPartition=$NORMALIZED_NODE_INDEX
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any usefull labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]