-
Notifications
You must be signed in to change notification settings - Fork 311
Perf release gate #9068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bric3
wants to merge
11
commits into
master
Choose a base branch
from
bdu/r-gate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+116
−0
Open
Perf release gate #9068
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
fdd30e5
chore(ci): Basic slo breach prototype
bric3 6407c42
chore(ci): PR review
bric3 736aefd
chore: Collect reports from benchmarks
bric3 361aaf6
tweak: Include benchmarkType in file name
ddyurchenko 92f9783
tweak: Store artifacts that were used for checking regression, so we …
ddyurchenko 67435a9
chore(ci): Tweak thresholds
bric3 616ae97
chore(ci): Tweak to recommended thresholds
bric3 0708dfb
Merge remote-tracking branch 'origin/master' into bdu/r-gate
bric3 98f9a31
chore(ci): Another tweak to recommended thresholds
bric3 098e012
chore(ci): Revert hack to run the release gate (it needed the all mac…
bric3 df915f0
Merge branch 'master' into bdu/r-gate
ddyurchenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
# Thresholds set based on guidance in https://datadoghq.atlassian.net/wiki/x/LgI1LgE#How-to-choose-thresholds-for-pre-release-gates%3F | ||
|
||
experiments: | ||
- name: Run SLO breach check | ||
steps: | ||
- name: SLO breach check | ||
run: fail_on_breach | ||
# https://datadoghq.atlassian.net/wiki/x/LgI1LgE#How-to-choose-a-warning-range-for-pre-release-gates%3F | ||
warning_range: 10 | ||
# File spec | ||
# https://datadoghq.atlassian.net/wiki/x/LgI1LgE#Specification | ||
# Measurements | ||
# https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario | ||
scenarios: | ||
# Note that thresholds there are choosen based the confidence interval with a 10% adjustment. | ||
|
||
# Standard macrobenchmarks | ||
# https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario&scenario=normal_operation%2Fonly-tracing&trendsType=scenario | ||
- name: normal_operation/only-tracing | ||
thresholds: | ||
- agg_http_req_duration_p50 < 2.6 ms | ||
- agg_http_req_duration_p99 < 8.5 ms | ||
# https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario&scenario=normal_operation%2Fotel-latest&trendsType=scenario | ||
- name: normal_operation/otel-latest | ||
thresholds: | ||
- agg_http_req_duration_p50 < 2.5 ms | ||
- agg_http_req_duration_p99 < 10 ms | ||
|
||
# https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario&scenario=high_load%2Fonly-tracing&trendsType=scenario | ||
- name: high_load/only-tracing | ||
thresholds: | ||
- throughput > 1100.0 op/s | ||
# https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario&scenario=high_load%2Fotel-latest&trendsType=scenario | ||
- name: high_load/otel-latest | ||
thresholds: | ||
- throughput > 1100.0 op/s | ||
|
||
# Startup macrobenchmarks | ||
# https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario&scenario=startup%3Apetclinic%3Atracing%3AGlobalTracer&trendsType=scenario | ||
# https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario&scenario=startup%3Apetclinic%3Aappsec%3AGlobalTracer&trendsType=scenario | ||
# https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario&scenario=startup%3Apetclinic%3Aiast%3AGlobalTracer&trendsType=scenario | ||
- name: "startup:petclinic:(tracing|appsec|iast):GlobalTracer" | ||
thresholds: | ||
- execution_time < 280 ms | ||
# https://benchmarking.us1.prod.dog/trends?projectId=4&branch=master&trendsTab=per_scenario&scenario=startup%3Apetclinic%3Aprofiling%3AGlobalTracer&trendsType=scenario | ||
- name: "startup:petclinic:profiling:GlobalTracer" | ||
thresholds: | ||
- execution_time < 420 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the results of https://gitlab.ddbuild.io/DataDog/apm-reliability/dd-trace-java/-/jobs/1031460223, I suggest to update the SLOs to the following values:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another tweak
