ci: run tests for legacy versions#935
Merged
KowalskiThomas merged 5 commits intomasterfrom Apr 9, 2026
Merged
Conversation
KowalskiThomas
force-pushed
the
kowalski/ci-run-tests-for-legacy-versions
branch
from
c33cbbb to
cd89cff
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cd89cffd8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
pyproject.toml lists configparser<5 as a runtime dep for Python 2. With skip_install=true the package install is skipped, so the dep must be declared explicitly in the affected envs (integration, integration-admin, py34).
This reverts commit 7a31a00.
skarimo
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR?
This PR adds support for running tests in Python 2.7 (which we still support) and 3.4 (which doesn't support type hints). Those cases require special handling because the default images used in GHA tests don't support 2.7 and 3.4 anymore.
For that to work:
test.ymlspecifically for older versions of Pythonhatchlingto run tests (by not installing the package for real)DD_ORIGIN_DETECTION_ENABLEDfor tests to avoid receiving thec:(container ID) tag which is unexpected in the test payloadsOn top of this, the PR fixes issues:
bytesparameters tobytes.joinstrobjects toopenwhich doesn't support receivingPosixPathin all Python versions