fix(dogstatsd): push cardinality for sampled metrics#929
Merged
KowalskiThomas merged 1 commit intomasterfrom Mar 31, 2026
Merged
fix(dogstatsd): push cardinality for sampled metrics#929KowalskiThomas merged 1 commit intomasterfrom
KowalskiThomas merged 1 commit intomasterfrom
Conversation
|
Bits Dev status: ✅ Done Comment @DataDog to request changes |
|
I can only run on private repositories. |
KowalskiThomas
added
the
changelog/Fixed
KowalskiThomas
force-pushed
the
dd/kowalski/fix/dogstatsd-sampled-cardinality
branch
from
239700a to
d941df4
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d941df4166
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: KowalskiThomas <14239160+KowalskiThomas@users.noreply.github.com>
KowalskiThomas
force-pushed
the
dd/kowalski/fix/dogstatsd-sampled-cardinality
branch
from
d941df4 to
8196a8c
Compare
vickenty
approved these changes
Mar 31, 2026
KowalskiThomas
deleted the
dd/kowalski/fix/dogstatsd-sampled-cardinality
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the
flush_aggregated_metricsfunction to properly forwardcardinality. Previously, this parameter was missing which would always set it to the default value defined inself._report(None).