Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
KowalskiThomas
added
changelog/Fixed
Co-authored-by: KowalskiThomas <14239160+KowalskiThomas@users.noreply.github.com>
KowalskiThomas
force-pushed
the
dd/kowalski/fix/max-sample-metric-rate-race-condition
branch
from
1013509 to
b14cca5
Compare
vickenty
approved these changes
Mar 31, 2026
KowalskiThomas
deleted the
dd/kowalski/fix/max-sample-metric-rate-race-condition
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a race condition in
MaxSampleMetric.flushwhere the sample rate was computed outside the lock, causing it to be inconsistent with the number of samples obtained inside the lock.