Skip to content

support dict for tags parameter #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
devsnek wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

support dict for tags parameter #732

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9668fe6
support dict for event/metric tags
devsnek Aug 25, 2022
5fce980
Update test_statsd.py
devsnek Aug 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions datadog/dogstatsd/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1026,6 +1026,8 @@ def service_check(
self._send(string)

def _add_constant_tags(self, tags):
if isinstance(tags, dict):
tags = list(map(lambda kv: '%s:%s' % kv, tags.items()))
if self.constant_tags:
if tags:
return tags + self.constant_tags
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/dogstatsd/test_statsd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,10 @@ def test_tagged_histogram(self):
self.statsd.histogram('h', 1, tags=['red'])
self.assert_equal_telemetry('h:1|h|#red\n', self.recv(2))

def test_dict_tagged(self):
self.statsd.increment('dct', tags={'country': 'españa'})
self.assert_equal_telemetry('dct:1|c|#country:españa\n', self.recv(2))

def test_sample_rate(self):
# Disabling telemetry since sample_rate imply randomness
self.statsd._telemetry = False
Expand Down