Replace olekukonko/tablewriter with stdlib text/tabwriter#49165
Replace olekukonko/tablewriter with stdlib text/tabwriter#49165gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intomainfrom
olekukonko/tablewriter with stdlib text/tabwriter#49165Conversation
Replace the external github.com/olekukonko/tablewriter dependency with Go's standard library text/tabwriter. The two usages (demultiplexer_agent_printer.go and routestats.go) only need simple tab-aligned table output, which text/tabwriter handles natively with zero external dependencies. Cell values are sanitized to replace tabs, newlines and carriage returns with spaces to prevent free-form text fields from corrupting the tabwriter column alignment. This change was originally part of the Kubernetes dependencies upgrade PR (#48796) and has been extracted into a standalone PR as suggested during code review. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
@codex review |
Go Package Import DifferencesBaseline: 2d6f5b3
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9d8aad161b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| func writeTable(w *bytes.Buffer, headers []string, data [][]string) { | ||
| tw := tabwriter.NewWriter(w, 0, 0, 1, ' ', 0) | ||
| fmt.Fprintln(tw, strings.ToUpper(strings.Join(headers, "\t"))) | ||
| sanitizer := strings.NewReplacer("\t", " ", "\n", " ", "\r", " ") |
There was a problem hiding this comment.
Sanitize all tabwriter control separators in table cells
writeTable only replaces \t, \n, and \r, but text/tabwriter also treats \v as a tab separator and \f as a line-break/flush delimiter. Because service-check messages are free-form, a payload containing either of those characters will still break column alignment (or split rows) in agent check --table output. Extending the sanitizer to normalize \v and \f avoids this regression from the previous renderer.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in d40f669 — added \v and \f to the sanitizer alongside the existing \t, \n, \r. Good catch.
Files inventory check summaryFile checks results against ancestor 2d6f5b3d: Results for datadog-agent_7.79.0~devel.git.605.d40f669.pipeline.107056367-1_amd64.deb:No change detected |
Add \v (vertical tab) and \f (form feed) to the cell sanitizer alongside \t, \n, and \r. These characters are treated specially by text/tabwriter and could corrupt column alignment if present in cell values. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: 5b413ef Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +3.05 | [+0.04, +6.06] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | docker_containers_cpu | % cpu utilization | +3.05 | [+0.04, +6.06] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +1.95 | [+1.80, +2.11] | 1 | Logs |
| ➖ | quality_gate_metrics_logs | memory utilization | +1.50 | [+1.26, +1.74] | 1 | Logs bounds checks dashboard |
| ➖ | ddot_logs | memory utilization | +0.61 | [+0.55, +0.67] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.59 | [+0.51, +0.67] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | +0.31 | [+0.15, +0.46] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.31 | [+0.25, +0.37] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | +0.12 | [-0.11, +0.35] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.07 | [+0.01, +0.13] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | +0.06 | [-0.06, +0.19] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.05 | [-0.11, +0.21] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.01 | [-0.09, +0.12] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.01 | [-0.17, +0.18] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | -0.00 | [-0.21, +0.20] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | -0.00 | [-0.21, +0.20] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | -0.03 | [-0.08, +0.02] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | -0.04 | [-0.44, +0.36] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.05 | [-0.59, +0.49] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | -0.08 | [-0.11, -0.05] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.12 | [-0.55, +0.32] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | -0.33 | [-0.47, -0.18] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | -0.87 | [-0.97, -0.77] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | -1.97 | [-3.56, -0.39] | 1 | Logs bounds checks dashboard |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 535 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 276.15MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 708 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.24GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.20GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.22GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 175.42MiB ≤ 181MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 498.52MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 4 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 206.19MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 371.22 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 408.28MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
2 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
olekukonko/tablewriter with stdlib text/tabwriter
…r` (#49165) ### What does this PR do? Replaces the external `github.com/olekukonko/tablewriter` dependency with Go's standard library `text/tabwriter`. The two usages (`demultiplexer_agent_printer.go` and `routestats.go`) only need simple tab-aligned table output, which `text/tabwriter` handles natively with zero external dependencies. Cell values are sanitized to replace tabs, newlines and carriage returns with spaces to prevent free-form text fields (e.g., service check messages) from corrupting the tabwriter column alignment. ### Motivation This change was originally part of the Kubernetes dependencies upgrade PR (#48796) and has been extracted into a standalone PR as [suggested during code review](#48796 (comment)). The `tablewriter` v1.1.0 upgrade (pulled transitively by `karpenter-provider-aws`) introduced several new transitive dependencies (`olekukonko/errors`, `olekukonko/ll`, `olekukonko/ts`) that increased binary size beyond the static quality gate threshold (600 KiB) for IoT and Heroku agent flavors. Replacing with the stdlib equivalent removes the dependency entirely, regardless of which version is pulled transitively. ### Describe how you validated your changes - `dda inv test --targets=./pkg/aggregator/...` — all 138 tests pass - `dda inv tidy` — go.mod/go.sum files are clean - Verified that `olekukonko/tablewriter` is no longer imported anywhere in the codebase ### Additional Notes The `mattn/go-runewidth` and `clipperhouse/uax29` indirect dependencies in `test/fakeintake/go.mod` were also removed as they were only needed by `tablewriter`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: lenaic.huard <lenaic.huard@datadoghq.com>
What does this PR do?
Replaces the external
github.com/olekukonko/tablewriterdependency with Go's standard librarytext/tabwriter. The two usages (demultiplexer_agent_printer.goandroutestats.go) only need simple tab-aligned table output, whichtext/tabwriterhandles natively with zero external dependencies.Cell values are sanitized to replace tabs, newlines and carriage returns with spaces to prevent free-form text fields (e.g., service check messages) from corrupting the tabwriter column alignment.
Motivation
This change was originally part of the Kubernetes dependencies upgrade PR (#48796) and has been extracted into a standalone PR as suggested during code review.
The
tablewriterv1.1.0 upgrade (pulled transitively bykarpenter-provider-aws) introduced several new transitive dependencies (olekukonko/errors,olekukonko/ll,olekukonko/ts) that increased binary size beyond the static quality gate threshold (600 KiB) for IoT and Heroku agent flavors. Replacing with the stdlib equivalent removes the dependency entirely, regardless of which version is pulled transitively.Describe how you validated your changes
dda inv test --targets=./pkg/aggregator/...— all 138 tests passdda inv tidy— go.mod/go.sum files are cleanolekukonko/tablewriteris no longer imported anywhere in the codebaseAdditional Notes
The
mattn/go-runewidthandclipperhouse/uax29indirect dependencies intest/fakeintake/go.modwere also removed as they were only needed bytablewriter.🤖 Generated with Claude Code