[Backport 7.78.x] [CXP-3401][agent][windows] Fix remote process collector missing from Windows build#48830
Conversation
Files inventory check summaryFile checks results against ancestor dbbcf5ea: Results for datadog-agent_7.78.0~rc.6.git.3.7fab1ce.pipeline.106217155-1_amd64.deb:No change detected |
Static quality checks✅ Please find below the results from static quality gates Successful checksInfo
30 successful checks with minimal change (< 2 KiB)
On-wire sizes (compressed)
|
Regression DetectorRegression Detector ResultsMetrics dashboard Baseline: dbbcf5e Optimization Goals: ✅ No significant changes detected
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | docker_containers_cpu | % cpu utilization | +6.36 | [+3.25, +9.47] | 1 | Logs |
Fine details of change detection per experiment
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ❌ | docker_containers_cpu | % cpu utilization | +6.36 | [+3.25, +9.47] | 1 | Logs |
| ➖ | quality_gate_logs | % cpu utilization | +1.71 | [+0.10, +3.33] | 1 | Logs bounds checks dashboard |
| ➖ | quality_gate_metrics_logs | memory utilization | +0.87 | [+0.63, +1.10] | 1 | Logs bounds checks dashboard |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.46 | [+0.31, +0.61] | 1 | Logs |
| ➖ | docker_containers_memory | memory utilization | +0.45 | [+0.38, +0.53] | 1 | Logs |
| ➖ | uds_dogstatsd_20mb_12k_contexts_20_senders | memory utilization | +0.27 | [+0.21, +0.32] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulative | memory utilization | +0.26 | [+0.12, +0.40] | 1 | Logs |
| ➖ | otlp_ingest_logs | memory utilization | +0.22 | [+0.12, +0.32] | 1 | Logs |
| ➖ | quality_gate_idle | memory utilization | +0.19 | [+0.14, +0.24] | 1 | Logs bounds checks dashboard |
| ➖ | file_tree | memory utilization | +0.13 | [+0.08, +0.19] | 1 | Logs |
| ➖ | quality_gate_idle_all_features | memory utilization | +0.11 | [+0.07, +0.15] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.09 | [-0.30, +0.49] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | +0.08 | [-0.43, +0.59] | 1 | Logs |
| ➖ | otlp_ingest_metrics | memory utilization | +0.07 | [-0.09, +0.23] | 1 | Logs |
| ➖ | ddot_metrics | memory utilization | +0.07 | [-0.12, +0.26] | 1 | Logs |
| ➖ | ddot_logs | memory utilization | +0.02 | [-0.04, +0.09] | 1 | Logs |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.02 | [-0.41, +0.45] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.01 | [-0.19, +0.21] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_v3 | ingress throughput | +0.01 | [-0.19, +0.21] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.10, +0.11] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.02 | [-0.11, +0.06] | 1 | Logs |
| ➖ | ddot_metrics_sum_cumulativetodelta_exporter | memory utilization | -0.04 | [-0.26, +0.19] | 1 | Logs |
| ➖ | ddot_metrics_sum_delta | memory utilization | -0.22 | [-0.39, -0.05] | 1 | Logs |
Bounds Checks: ✅ Passed
| perf | experiment | bounds_check_name | replicates_passed | observed_value | links |
|---|---|---|---|---|---|
| ✅ | docker_containers_cpu | simple_check_run | 10/10 | 680 ≥ 26 | |
| ✅ | docker_containers_memory | memory_usage | 10/10 | 276.41MiB ≤ 370MiB | |
| ✅ | docker_containers_memory | simple_check_run | 10/10 | 704 ≥ 26 | |
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_0ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 | 0.23GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_1000ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 | 0.19GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_100ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 | 0.22GiB ≤ 1.20GiB | |
| ✅ | file_to_blackhole_500ms_latency | missed_bytes | 10/10 | 0B = 0B | |
| ✅ | quality_gate_idle | intake_connections | 10/10 | 3 = 3 | bounds checks dashboard |
| ✅ | quality_gate_idle | memory_usage | 10/10 | 173.67MiB ≤ 175MiB | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | intake_connections | 10/10 | 2 ≤ 3 | bounds checks dashboard |
| ✅ | quality_gate_idle_all_features | memory_usage | 10/10 | 490.91MiB ≤ 550MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_logs | memory_usage | 10/10 | 205.43MiB ≤ 220MiB | bounds checks dashboard |
| ✅ | quality_gate_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | cpu_usage | 10/10 | 368.41 ≤ 2000 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | intake_connections | 10/10 | 3 ≤ 6 | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | memory_usage | 10/10 | 415.64MiB ≤ 475MiB | bounds checks dashboard |
| ✅ | quality_gate_metrics_logs | missed_bytes | 10/10 | 0B = 0B | bounds checks dashboard |
Explanation
Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%
Performance changes are noted in the perf column of each table:
- ✅ = significantly better comparison variant performance
- ❌ = significantly worse comparison variant performance
- ➖ = no significant change in performance
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
CI Pass/Fail Decision
✅ Passed. All Quality Gates passed.
- quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
- quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.
|
cherry picked commit from #48833 to clean up e2e test |
…Windows build (#48819) ## Summary - Fixes remote process collector missing from Windows build, restoring language detection - Adds a Windows E2E test for language detection via the `remote_process_collector` to the existing `windowsTestSuite` ## What's broken PR #46219 split the workloadmeta catalog into `trivy` / `!trivy` variants but only included `remoteprocesscollector` in the `trivy`-gated file (`options.go`). Since `trivy` is in `LINUX_ONLY_TAGS`, Windows always uses the `!trivy` build (`options_nosbom.go`) — which is missing the remote process collector. This broke language detection on Windows since March 20. More details in jira ticket: https://datadoghq.atlassian.net/browse/CXP-3401 ## Evidence - [Diff that introduced the regression](20aa50f) — `options_nosbom.go` created without `remoteprocesscollector` - [LINUX_ONLY_TAGS includes trivy](https://github.com/DataDog/datadog-agent/blob/main/tasks/build_tags.py) — confirms Windows never gets the `trivy` build - Validated on Windows Server EC2 running agent 7.78.0-rc.5: - `agent workload-list --json` returns `{"Entities":{}}` - Agent logs show no `remote-process-collector` among workloadmeta collector candidates - Config confirms `language_detection.enabled: true` ## Why the test lives in `tests/process/` instead of `tests/language-detection/` The test is added to the existing `windowsTestSuite` in `tests/process/windows_test.go` to reuse the same Windows EC2 instance already provisioned by the `new-e2e-process-windows` CI job for efficiency rather than logical organization. Placing it in `tests/language-detection/` would require a separate Windows CI job and provision an additional Windows instance, adding ~10 min of extra CI time. ## Test plan - [x] CI passes - [x] E2E test confirms regression (fails against 7.78.0-rc.5 with `{"Entities":{}}`) (details in jira comment: https://datadoghq.atlassian.net/browse/CXP-3401?focusedCommentId=3134649) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: matthew.geng <matthew.geng@datadoghq.com> (cherry picked from commit 3fc1dc8) ___ Co-authored-by: Matthew Geng <matthew.geng@datadoghq.com>
Remove PID matching from TestLanguageDetectionWindows and check for any process with language=python instead. The SSH session wraps commands in PowerShell, causing the PID from Get-CimInstance to differ from the one in workloadmeta, leading to false failures. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
5b0fb02 to
7fab1ce
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
Backport 3fc1dc8 from #48819.
Summary
remote_process_collectorto the existingwindowsTestSuiteWhat's broken
PR #46219 split the workloadmeta catalog into
trivy/!trivyvariants but only includedremoteprocesscollectorin thetrivy-gated file (options.go). Sincetrivyis inLINUX_ONLY_TAGS, Windows always uses the!trivybuild (options_nosbom.go) — which is missing the remote process collector. This broke language detection on Windows since March 20. More details in jira ticket: https://datadoghq.atlassian.net/browse/CXP-3401Evidence
options_nosbom.gocreated withoutremoteprocesscollectortrivybuildagent workload-list --jsonreturns{"Entities":{}}remote-process-collectoramong workloadmeta collector candidateslanguage_detection.enabled: trueWhy the test lives in
tests/process/instead oftests/language-detection/The test is added to the existing
windowsTestSuiteintests/process/windows_test.goto reuse the same Windows EC2 instance already provisioned by thenew-e2e-process-windowsCI job for efficiency rather than logical organization. Placing it intests/language-detection/would require a separate Windows CI job and provision an additional Windows instance, adding ~10 min of extra CI time.Test plan
{"Entities":{}}) (details in jira comment: https://datadoghq.atlassian.net/browse/CXP-3401?focusedCommentId=3134649)Ran the python script
We can see the python language appear
🤖 Generated with Claude Code