Skip to content

bazel: enable --experimental_strict_repo_env#48713

Draft
rdesgroppes wants to merge 1 commit intomainfrom
regis.desgroppes/strict-repo-env
Draft

bazel: enable --experimental_strict_repo_env#48713
rdesgroppes wants to merge 1 commit intomainfrom
regis.desgroppes/strict-repo-env

Conversation

@rdesgroppes
Copy link
Copy Markdown
Contributor

Prevent ambient environment variables from leaking into repository rules. Only PATH (and PATHEXT on Windows) plus variables explicitly forwarded via --repo_env are now visible to repository rules.

Introduced in Bazel 8.6.0 (bazelbuild/bazel#28189), this is the repository-rule counterpart to --incompatible_strict_action_env.

What does this PR do?

Motivation

Describe how you validated your changes

Additional Notes

Prevent ambient environment variables from leaking into repository
rules. Only PATH (and PATHEXT on Windows) plus variables explicitly
forwarded via --repo_env are now visible to repository rules.

Introduced in Bazel 8.6.0 (bazelbuild/bazel#28189), this is the
repository-rule counterpart to --incompatible_strict_action_env.
@rdesgroppes rdesgroppes added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 31, 2026
@dd-octo-sts dd-octo-sts bot added the internal Identify a non-fork PR label Mar 31, 2026
@github-actions github-actions bot added the short review PR is simple enough to be reviewed quickly label Mar 31, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

Files inventory check summary

File checks results against ancestor b53dfa9d:

Results for datadog-agent_7.79.0~devel.git.328.6dbf2eb.pipeline.105389973-1_amd64.deb:

Detected file changes:

1 Added files:

  • opt/datadog-packages/run/datadog-agent/_build_version_unset_ (18.0 B)

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: 944f3c6c-b24c-42d9-9932-d579f28ea49b

Baseline: b53dfa9
Comparison: 6dbf2eb
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization -0.66 [-3.61, +2.28] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_metrics_logs memory utilization +0.74 [+0.50, +0.98] 1 Logs bounds checks dashboard
quality_gate_idle_all_features memory utilization +0.42 [+0.38, +0.45] 1 Logs bounds checks dashboard
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization +0.34 [+0.28, +0.40] 1 Logs
file_tree memory utilization +0.24 [+0.19, +0.30] 1 Logs
otlp_ingest_metrics memory utilization +0.13 [-0.03, +0.29] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.11 [-0.40, +0.61] 1 Logs
ddot_metrics memory utilization +0.07 [-0.10, +0.24] 1 Logs
docker_containers_memory memory utilization +0.06 [-0.02, +0.15] 1 Logs
quality_gate_idle memory utilization +0.06 [+0.01, +0.10] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +0.03 [-0.14, +0.20] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput -0.00 [-0.19, +0.19] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.01 [-0.11, +0.10] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.01 [-0.11, +0.09] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.02 [-0.44, +0.40] 1 Logs
otlp_ingest_logs memory utilization -0.02 [-0.13, +0.08] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.02 [-0.23, +0.18] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.06 [-0.46, +0.33] 1 Logs
ddot_metrics_sum_cumulative memory utilization -0.15 [-0.29, -0.01] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.15 [-0.37, +0.07] 1 Logs
ddot_logs memory utilization -0.37 [-0.43, -0.32] 1 Logs
docker_containers_cpu % cpu utilization -0.66 [-3.61, +2.28] 1 Logs
quality_gate_logs % cpu utilization -1.63 [-3.21, -0.05] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -1.94 [-2.09, -1.80] 1 Logs

Bounds Checks: ✅ Passed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 703 ≥ 26
docker_containers_memory memory_usage 10/10 272.19MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 688 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.24GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.20GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 10/10 173.52MiB ≤ 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 492.73MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 204.13MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 368.30 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 3 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 426.58MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Passed. All Quality Gates passed.

  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 10/10 replicas passed. Gate passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog No changelog entry needed internal Identify a non-fork PR qa/no-code-change No code change in Agent code requiring validation short review PR is simple enough to be reviewed quickly team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant