Skip to content

[ABLD-425] More L2. comps/logs-library, pkg/aggregator/ckey#48689

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
aiuto/l2
Apr 1, 2026
Merged

[ABLD-425] More L2. comps/logs-library, pkg/aggregator/ckey#48689
gh-worker-dd-mergequeue-cf854d[bot] merged 3 commits intomainfrom
aiuto/l2

Conversation

@aiuto
Copy link
Copy Markdown
Contributor

@aiuto aiuto commented Mar 31, 2026

ABLD-425 More layer 2 packages.

  • comp/logs-library
  • pkg/aggregator/ckey

aiuto added 2 commits March 31, 2026 12:02
- comp/logs-library
- pkg/aggregator/ckey
@aiuto aiuto added changelog/no-changelog No changelog entry needed qa/no-code-change No code change in Agent code requiring validation labels Mar 31, 2026
@dd-octo-sts dd-octo-sts bot added internal Identify a non-fork PR team/agent-build labels Mar 31, 2026
@github-actions github-actions bot added the medium review PR review might take time label Mar 31, 2026
@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Mar 31, 2026

Files inventory check summary

File checks results against ancestor a355cb90:

Results for datadog-agent_7.79.0~devel.git.327.6a4f377.pipeline.105372770-1_amd64.deb:

No change detected

@agent-platform-auto-pr
Copy link
Copy Markdown
Contributor

agent-platform-auto-pr bot commented Mar 31, 2026

Static quality checks

✅ Please find below the results from static quality gates
Comparison made with ancestor a355cb9
📊 Static Quality Gates Dashboard
🔗 SQG Job

30 successful checks with minimal change (< 2 KiB)
Quality gate Current Size
agent_deb_amd64 753.085 MiB
agent_deb_amd64_fips 710.016 MiB
agent_heroku_amd64 313.321 MiB
agent_rpm_amd64 753.069 MiB
agent_rpm_amd64_fips 710.000 MiB
agent_rpm_arm64 731.487 MiB
agent_rpm_arm64_fips 691.447 MiB
agent_suse_amd64 753.069 MiB
agent_suse_amd64_fips 710.000 MiB
agent_suse_arm64 731.487 MiB
agent_suse_arm64_fips 691.447 MiB
docker_agent_amd64 813.387 MiB
docker_agent_arm64 816.576 MiB
docker_agent_jmx_amd64 1004.303 MiB
docker_agent_jmx_arm64 996.270 MiB
docker_cluster_agent_amd64 203.957 MiB
docker_cluster_agent_arm64 218.419 MiB
docker_cws_instrumentation_amd64 7.142 MiB
docker_cws_instrumentation_arm64 6.689 MiB
docker_dogstatsd_amd64 39.234 MiB
docker_dogstatsd_arm64 37.445 MiB
dogstatsd_deb_amd64 29.878 MiB
dogstatsd_deb_arm64 28.030 MiB
dogstatsd_rpm_amd64 29.878 MiB
dogstatsd_suse_amd64 29.878 MiB
iot_agent_deb_amd64 43.289 MiB
iot_agent_deb_arm64 40.336 MiB
iot_agent_deb_armhf 41.084 MiB
iot_agent_rpm_amd64 43.290 MiB
iot_agent_suse_amd64 43.290 MiB
On-wire sizes (compressed)
Quality gate Change Size (prev → curr → max)
agent_deb_amd64 -10.94 KiB (0.01% reduction) 174.776 → 174.766 → 178.360
agent_deb_amd64_fips neutral 165.378 MiB → 172.790
agent_heroku_amd64 neutral 75.004 MiB → 79.970
agent_rpm_amd64 +7.74 KiB (0.00% increase) 177.617 → 177.624 → 181.830
agent_rpm_amd64_fips +15.23 KiB (0.01% increase) 167.675 → 167.690 → 173.370
agent_rpm_arm64 -16.74 KiB (0.01% reduction) 159.576 → 159.560 → 163.060
agent_rpm_arm64_fips +16.68 KiB (0.01% increase) 151.417 → 151.433 → 156.170
agent_suse_amd64 +7.74 KiB (0.00% increase) 177.617 → 177.624 → 181.830
agent_suse_amd64_fips +15.23 KiB (0.01% increase) 167.675 → 167.690 → 173.370
agent_suse_arm64 -16.74 KiB (0.01% reduction) 159.576 → 159.560 → 163.060
agent_suse_arm64_fips +16.68 KiB (0.01% increase) 151.417 → 151.433 → 156.170
docker_agent_amd64 neutral 268.194 MiB → 272.480
docker_agent_arm64 neutral 255.388 MiB → 261.060
docker_agent_jmx_amd64 neutral 336.847 MiB → 341.100
docker_agent_jmx_arm64 neutral 320.029 MiB → 325.620
docker_cluster_agent_amd64 neutral 71.376 MiB → 72.920
docker_cluster_agent_arm64 neutral 67.010 MiB → 68.220
docker_cws_instrumentation_amd64 neutral 2.999 MiB → 3.330
docker_cws_instrumentation_arm64 neutral 2.729 MiB → 3.090
docker_dogstatsd_amd64 neutral 15.174 MiB → 15.820
docker_dogstatsd_arm64 neutral 14.490 MiB → 14.830
dogstatsd_deb_amd64 neutral 7.895 MiB → 8.790
dogstatsd_deb_arm64 neutral 6.778 MiB → 7.710
dogstatsd_rpm_amd64 neutral 7.905 MiB → 8.800
dogstatsd_suse_amd64 neutral 7.905 MiB → 8.800
iot_agent_deb_amd64 neutral 11.404 MiB → 12.040
iot_agent_deb_arm64 neutral 9.705 MiB → 10.450
iot_agent_deb_armhf neutral 9.943 MiB → 10.620
iot_agent_rpm_amd64 neutral 11.421 MiB → 12.060
iot_agent_suse_amd64 neutral 11.421 MiB → 12.060

@cit-pr-commenter-54b7da
Copy link
Copy Markdown

cit-pr-commenter-54b7da bot commented Mar 31, 2026

Regression Detector

Regression Detector Results

Metrics dashboard
Target profiles
Run ID: f001494e-ce45-48dd-9c2d-99005ce8d4b5

Baseline: 17bc5b5
Comparison: 28617db
Diff

Optimization Goals: ✅ No significant changes detected

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI trials links
docker_containers_cpu % cpu utilization +1.97 [-1.06, +5.01] 1 Logs

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
quality_gate_logs % cpu utilization +4.20 [+2.55, +5.85] 1 Logs bounds checks dashboard
docker_containers_cpu % cpu utilization +1.97 [-1.06, +5.01] 1 Logs
tcp_syslog_to_blackhole ingress throughput +1.71 [+1.55, +1.88] 1 Logs
otlp_ingest_metrics memory utilization +1.28 [+1.13, +1.44] 1 Logs
otlp_ingest_logs memory utilization +0.95 [+0.84, +1.05] 1 Logs
quality_gate_metrics_logs memory utilization +0.82 [+0.58, +1.06] 1 Logs bounds checks dashboard
ddot_metrics memory utilization +0.62 [+0.44, +0.79] 1 Logs
ddot_metrics_sum_cumulative memory utilization +0.30 [+0.16, +0.44] 1 Logs
quality_gate_idle memory utilization +0.21 [+0.16, +0.26] 1 Logs bounds checks dashboard
ddot_metrics_sum_delta memory utilization +0.13 [-0.03, +0.30] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.04 [-0.46, +0.54] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.03 [-0.37, +0.42] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.02 [-0.18, +0.22] 1 Logs
uds_dogstatsd_to_api_v3 ingress throughput +0.01 [-0.19, +0.20] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.00 [-0.08, +0.09] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.11, +0.10] 1 Logs
uds_dogstatsd_20mb_12k_contexts_20_senders memory utilization -0.06 [-0.12, +0.01] 1 Logs
file_tree memory utilization -0.08 [-0.14, -0.03] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.11 [-0.54, +0.32] 1 Logs
ddot_metrics_sum_cumulativetodelta_exporter memory utilization -0.20 [-0.42, +0.02] 1 Logs
ddot_logs memory utilization -0.21 [-0.28, -0.14] 1 Logs
quality_gate_idle_all_features memory utilization -0.23 [-0.27, -0.19] 1 Logs bounds checks dashboard
docker_containers_memory memory utilization -0.30 [-0.38, -0.21] 1 Logs

Bounds Checks: ❌ Failed

perf experiment bounds_check_name replicates_passed observed_value links
docker_containers_cpu simple_check_run 10/10 677 ≥ 26
docker_containers_memory memory_usage 10/10 271.06MiB ≤ 370MiB
docker_containers_memory simple_check_run 10/10 691 ≥ 26
file_to_blackhole_0ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_0ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_1000ms_latency memory_usage 10/10 0.23GiB ≤ 1.20GiB
file_to_blackhole_1000ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_100ms_latency memory_usage 10/10 0.19GiB ≤ 1.20GiB
file_to_blackhole_100ms_latency missed_bytes 10/10 0B = 0B
file_to_blackhole_500ms_latency memory_usage 10/10 0.21GiB ≤ 1.20GiB
file_to_blackhole_500ms_latency missed_bytes 10/10 0B = 0B
quality_gate_idle intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle memory_usage 9/10 175.14MiB > 175MiB bounds checks dashboard
quality_gate_idle_all_features intake_connections 10/10 3 = 3 bounds checks dashboard
quality_gate_idle_all_features memory_usage 10/10 495.12MiB ≤ 550MiB bounds checks dashboard
quality_gate_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_logs memory_usage 10/10 205.11MiB ≤ 220MiB bounds checks dashboard
quality_gate_logs missed_bytes 10/10 0B = 0B bounds checks dashboard
quality_gate_metrics_logs cpu_usage 10/10 357.66 ≤ 2000 bounds checks dashboard
quality_gate_metrics_logs intake_connections 10/10 4 ≤ 6 bounds checks dashboard
quality_gate_metrics_logs memory_usage 10/10 410.28MiB ≤ 475MiB bounds checks dashboard
quality_gate_metrics_logs missed_bytes 10/10 0B = 0B bounds checks dashboard

Explanation

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

CI Pass/Fail Decision

Failed. Some Quality Gates were violated.

  • quality_gate_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_idle_all_features, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check intake_connections: 10/10 replicas passed. Gate passed.
  • quality_gate_idle, bounds check memory_usage: 9/10 replicas passed. Failed 1 which is > 0. Gate FAILED.
  • quality_gate_metrics_logs, bounds check memory_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check missed_bytes: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check cpu_usage: 10/10 replicas passed. Gate passed.
  • quality_gate_metrics_logs, bounds check intake_connections: 10/10 replicas passed. Gate passed.

@aiuto aiuto marked this pull request as ready for review March 31, 2026 17:56
@aiuto aiuto requested a review from a team as a code owner March 31, 2026 17:56
@aiuto aiuto added the ask-review Ask required teams to review this PR label Mar 31, 2026
@aiuto aiuto changed the title [ABLD-425] More layer 2 packages. [ABLD-425] More L2. comps/logs-library, pkg/aggregator/ckey Mar 31, 2026
@aiuto
Copy link
Copy Markdown
Contributor Author

aiuto commented Apr 1, 2026

/merge

@gh-worker-devflow-routing-ef8351
Copy link
Copy Markdown

gh-worker-devflow-routing-ef8351 bot commented Apr 1, 2026

View all feedbacks in Devflow UI.

2026-04-01 14:45:19 UTC ℹ️ Start processing command /merge


2026-04-01 14:45:24 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-04-01 16:52:28 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot merged commit 28617db into main Apr 1, 2026
244 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d bot deleted the aiuto/l2 branch April 1, 2026 16:52
@github-actions github-actions bot added this to the 7.79.0 milestone Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ask-review Ask required teams to review this PR changelog/no-changelog No changelog entry needed internal Identify a non-fork PR medium review PR review might take time qa/no-code-change No code change in Agent code requiring validation team/agent-build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants