test/e2e-framework: support kind cluster topology and image customization#48684
test/e2e-framework: support kind cluster topology and image customization#48684AlexanderYastrebov wants to merge 1 commit intomainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c28176bd9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| return fmt.Sprintf("kind load docker-image %s --name %s", img, name) | ||
| }).(pulumi.StringOutput), | ||
| }, | ||
| utils.PulumiDependsOn(kindCluster), |
There was a problem hiding this comment.
The image preload commands only use DependsOn(kindCluster) for ordering, but they have no trigger tied to cluster recreation, so Pulumi treats them as unchanged when the Kind cluster is replaced with the same name (for example after topology/version changes or stack updates in dev mode). In that case the new cluster starts without the preloaded images, and agent pods configured with imagePullPolicy: Never can fail to start because the image load step is skipped.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Claude suggested to add
// Trigger re-run when the cluster is recreated. KubeConfig changes on
// every new cluster (new TLS certs), so this ensures the image is
// reloaded into the replacement cluster even when the cluster name and
// image haven't changed.
Triggers: pulumi.Array{kindCluster.KubeConfig},which I did.
AlexanderYastrebov
added
qa/done
Files inventory check summaryFile checks results against ancestor 082be224: Results for datadog-agent_7.79.0~devel.git.311.4122e59.pipeline.105299919-1_amd64.deb:No change detected |
…tion Add support for customizing kind cluster topology and pre-loading Docker images into the cluster before the agent is deployed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AlexanderYastrebov
force-pushed
the
alexander.yastrebov/test/e2e-framework/kind-customization
branch
from
8c28176 to
4122e59
Compare
1 participant
What does this PR do?
Add support for customizing kind cluster topology and pre-loading Docker images into the cluster before the agent is deployed.
Motivation
Local e2e tests for Spot Scheduling #47429
Describe how you validated your changes
I am testing spot scheduling and extracted these chnages into a separate PR.
Additional Notes