Add dts profile diff #999
Open
Add dts profile diff #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
It's done so generated profiles are identical to reference ones Signed-off-by: Michał Iwanicki <[email protected]>
Used by 'Get File From DUT' keyword Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
m-iwanicki
commented
Aug 20, 2025
dts/profiles/msi-pro-z790-p-ddr5 UEFI->Heads Transition - DPP.profile
Show resolved
Hide resolved
add support for per workflow/release exports Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Eduard Kaverinskyi <[email protected]>
|
I cherry-picked commit from this PR: #647 to fix Dasharo/dasharo-issues#1526 |
Signed-off-by: Michał Iwanicki <[email protected]>
m-iwanicki
commented
Aug 22, 2025
dts/profiles/msi-pro-z690-a-ddr5 UEFI->Heads Transition - DPP.profile
Show resolved
Hide resolved
DaniilKl
requested changes
Aug 22, 2025
dts/profiles/msi-pro-z790-p-ddr5 UEFI->Heads Transition - DPP.profile
Show resolved
Hide resolved
dts/profiles/msi-pro-z690-a-ddr5 UEFI->Heads Transition - DPP.profile
Show resolved
Hide resolved
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]>
Signed-off-by: Daniil Klimuk <[email protected]> dts: profile: optiplex-[79]010: add Initial deployment profiles Signed-off-by: Daniil Klimuk <[email protected]> dts: profiles: add OptiPlex UEFI Update profiles Signed-off-by: Daniil Klimuk <[email protected]> platform-configs: optiplex-common: fix pre-commit Signed-off-by: Daniil Klimuk <[email protected]> platform-configs: optiplex: delete DTS TEST_*_MIGRATED vars Signed-off-by: Daniil Klimuk <[email protected]> platform-configs: optiplex: delete TEST_IS_COREBOOT Signed-off-by: Daniil Klimuk <[email protected]>
Either transition didn't work or couldn't be verified Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
|
Looks ok. Lets check the tests results. |
|
@DaniilKl partial results: Needs to be fixed:
|
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
Signed-off-by: Michał Iwanicki <[email protected]>
m-iwanicki
force-pushed
the
add-dts-profile-diff
branch
from
107a205 to
9c51db6
Compare
|
@DaniilKl results: 61 tests, 57 passed, 4 failed
2 failures are expected (1 non-working heads transition on Z790 and 1 unverified heads transition). |
|
Every test passed except those 2 expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Dasharo/dts-scripts#97 (needs those changes to work).
UEFI Update profile will need to be generated again because of Dasharo/dts-scripts@171d8de
This PR adds basic support for profile checking along with implementing those checks for ODROID H4 workflows.
Comparing profiles is done in TRY block:
open-source-firmware-validation/dts/dts-e2e.robot
Line 169 in 4e0efd9
Maybe adding separate variable in platform config to decide whether profile has to be checked for that workflow would be good idea just in case file or test is renamed. In the current state test would succeed, because it would skip profile checking if it couldn't find reference file.