Adds Maximum Age Limit#1023
Merged
chazzyjazzy merged 5 commits intoDarkPack13:masterfrom May 7, 2026
Merged
Conversation
Contributor
|
You currently have a negative Fix/Feature pull request delta of -22. Maintainers may close this PR at will. Fixing issues or improving the codebase will improve this score. |
FalloutFalcon
requested changes
May 6, 2026
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
FalloutFalcon
approved these changes
May 6, 2026
Co-authored-by: FalloutFalcon <86381784+FalloutFalcon@users.noreply.github.com>
chazzyjazzy
approved these changes
May 6, 2026
Contributor
|
Your Fix/Feature pull request is currently below zero (-28). Maintainers may close future Feature/Balance PRs. Fixing issues or helping to improve the codebase will raise this score. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About The Pull Request
This was requested over on TFN, I saw players and staff both discussing this and got the go-ahead from lore staff to add a simple support for it.
I did not change any values as this is meant to be used by the individual servers if they choose to use this support. This I believe was intended for certain roles, i.e stripper, from being played by old immortal vampires. We can't have Dark Age strippers, sigh.....
Shoved this on hound purely to show it works, stops joining as the role akin to how generation or being too young does. (Hound file not harmed in the making of this PR.)
Why It's Good For The Game
Overall just adds support that TFN and other downstreams may make use of to limit lower-run society jobs from elder vampires. Pretty light-weight since the max age is set above what you should be able to choose for a vampire anyway without admin interference.
Changelog
🆑
add: Adds maximum immortal age variable for jobs.
/:cl: