-
Notifications
You must be signed in to change notification settings - Fork 29
Robot Upgrade: prometheus-node-exporter chart upgrade from 4.6.0 to 4.49.2 #3770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,10 @@ | ||
| annotations: | ||
| artifacthub.io/license: Apache-2.0 | ||
| artifacthub.io/links: | | ||
| - name: Chart Source | ||
| url: https://github.com/prometheus-community/helm-charts | ||
| apiVersion: v2 | ||
| appVersion: 1.3.1 | ||
| appVersion: 1.10.2 | ||
| description: A Helm chart for prometheus node-exporter | ||
| home: https://github.com/prometheus/node_exporter/ | ||
| keywords: | ||
|
|
@@ -9,14 +14,19 @@ keywords: | |
| maintainers: | ||
| - email: [email protected] | ||
| name: gianrubio | ||
| url: https://github.com/gianrubio | ||
| - email: [email protected] | ||
| name: zanhsieh | ||
| url: https://github.com/zanhsieh | ||
| - email: [email protected] | ||
| name: zeritti | ||
| url: https://github.com/zeritti | ||
| name: prometheus-node-exporter | ||
| sources: | ||
| - https://github.com/prometheus/node_exporter/ | ||
| type: application | ||
| version: 4.6.0 | ||
| version: 4.49.2 | ||
| dependencies: | ||
| - name: prometheus-node-exporter | ||
| version: "4.6.0" | ||
| version: "4.49.2" | ||
| repository: "https://prometheus-community.github.io/helm-charts" | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,3 +19,5 @@ | |
| .project | ||
| .idea/ | ||
| *.tmproj | ||
|
|
||
| ci/ | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,10 @@ | ||
| annotations: | ||
| artifacthub.io/license: Apache-2.0 | ||
| artifacthub.io/links: | | ||
| - name: Chart Source | ||
| url: https://github.com/prometheus-community/helm-charts | ||
| apiVersion: v2 | ||
| appVersion: 1.3.1 | ||
| appVersion: 1.10.2 | ||
| description: A Helm chart for prometheus node-exporter | ||
| home: https://github.com/prometheus/node_exporter/ | ||
| keywords: | ||
|
|
@@ -9,10 +14,15 @@ keywords: | |
| maintainers: | ||
| - email: [email protected] | ||
| name: gianrubio | ||
| url: https://github.com/gianrubio | ||
| - email: [email protected] | ||
| name: zanhsieh | ||
| url: https://github.com/zanhsieh | ||
| - email: [email protected] | ||
| name: zeritti | ||
| url: https://github.com/zeritti | ||
| name: prometheus-node-exporter | ||
| sources: | ||
| - https://github.com/prometheus/node_exporter/ | ||
| type: application | ||
| version: 4.6.0 | ||
| version: 4.49.2 | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,29 +1,29 @@ | ||||||
| # Prometheus `Node Exporter` | ||||||
| # Prometheus Node Exporter | ||||||
|
|
||||||
| Prometheus exporter for hardware and OS metrics exposed by *NIX kernels, written in Go with pluggable metric collectors. | ||||||
|
|
||||||
| This chart bootstraps a prometheus [`Node Exporter`](http://github.com/prometheus/node_exporter) daemonset on a [Kubernetes](http://kubernetes.io) cluster using the [Helm](https://helm.sh) package manager. | ||||||
| This chart bootstraps a Prometheus [Node Exporter](http://github.com/prometheus/node_exporter) daemonset on a [Kubernetes](http://kubernetes.io) cluster using the [Helm](https://helm.sh) package manager. | ||||||
|
|
||||||
| ## Get Repository Info | ||||||
| ## Usage | ||||||
|
|
||||||
| ```console | ||||||
| helm repo add prometheus-community https://prometheus-community.github.io/helm-charts | ||||||
| helm repo update | ||||||
| ``` | ||||||
| The chart is distributed as an [OCI Artifact](https://helm.sh/docs/topics/registries/) as well as via a traditional [Helm Repository](https://helm.sh/docs/topics/chart_repository/). | ||||||
|
|
||||||
| - OCI Artifact: `oci://ghcr.io/prometheus-community/charts/prometheus-node-exporter` | ||||||
| - Helm Repository: `https://prometheus-community.github.io/helm-charts` with chart `prometheus-node-exporter` | ||||||
|
|
||||||
| _See [`helm repo`](https://helm.sh/docs/helm/helm_repo/) for command documentation._ | ||||||
| The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository. | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There appears to be a formatting error in the markdown link. The link tag is nested within itself, which may cause rendering issues in some markdown viewers.
Suggested change
|
||||||
|
|
||||||
| ## Install Chart | ||||||
| ### Install Chart | ||||||
|
|
||||||
| ```console | ||||||
| helm install [RELEASE_NAME] prometheus-community/prometheus-node-exporter | ||||||
| helm install [RELEASE_NAME] oci://ghcr.io/prometheus-community/charts/prometheus-node-exporter | ||||||
| ``` | ||||||
|
|
||||||
| _See [configuration](#configuring) below._ | ||||||
|
|
||||||
| _See [helm install](https://helm.sh/docs/helm/helm_install/) for command documentation._ | ||||||
|
|
||||||
| ## Uninstall Chart | ||||||
| ### Uninstall Chart | ||||||
|
|
||||||
| ```console | ||||||
| helm uninstall [RELEASE_NAME] | ||||||
|
|
@@ -33,15 +33,15 @@ This removes all the Kubernetes components associated with the chart and deletes | |||||
|
|
||||||
| _See [helm uninstall](https://helm.sh/docs/helm/helm_uninstall/) for command documentation._ | ||||||
|
|
||||||
| ## Upgrading Chart | ||||||
| ### Upgrading Chart | ||||||
|
|
||||||
| ```console | ||||||
| helm upgrade [RELEASE_NAME] [CHART] --install | ||||||
| helm upgrade [RELEASE_NAME] oci://ghcr.io/prometheus-community/charts/prometheus-node-exporter --install | ||||||
| ``` | ||||||
|
|
||||||
| _See [helm upgrade](https://helm.sh/docs/helm/helm_upgrade/) for command documentation._ | ||||||
|
|
||||||
| ### 3.x to 4.x | ||||||
| #### 3.x to 4.x | ||||||
|
|
||||||
| Starting from version 4.0.0, the `node exporter` chart is using the [Kubernetes recommended labels](https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/). Therefore you have to delete the daemonset before you upgrade. | ||||||
|
|
||||||
|
|
@@ -50,9 +50,9 @@ kubectl delete daemonset -l app=prometheus-node-exporter | |||||
| helm upgrade -i prometheus-node-exporter prometheus-community/prometheus-node-exporter | ||||||
| ``` | ||||||
|
|
||||||
| If you use your own custom [ServiceMonitor](https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#servicemonitor) or [PodMonitor](https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api.md#podmonitor), please ensure to upgrade their `selector` fields accordingly to the new labels. | ||||||
| If you use your own custom [ServiceMonitor](https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api-reference/api.md#servicemonitor) or [PodMonitor](https://github.com/prometheus-operator/prometheus-operator/blob/main/Documentation/api-reference/api.md#podmonitor), please ensure to upgrade their `selector` fields accordingly to the new labels. | ||||||
|
|
||||||
| ### From 2.x to 3.x | ||||||
| #### From 2.x to 3.x | ||||||
|
|
||||||
| Change the following: | ||||||
|
|
||||||
|
|
@@ -73,5 +73,24 @@ hostRootFsMount: | |||||
| See [Customizing the Chart Before Installing](https://helm.sh/docs/intro/using_helm/#customizing-the-chart-before-installing). To see all configurable options with detailed comments, visit the chart's [values.yaml](./values.yaml), or run these configuration commands: | ||||||
|
|
||||||
| ```console | ||||||
| helm show values prometheus-community/prometheus-node-exporter | ||||||
| helm show values oci://ghcr.io/prometheus-community/charts/prometheus-node-exporter | ||||||
| ``` | ||||||
|
|
||||||
| ### kube-rbac-proxy | ||||||
|
|
||||||
| You can enable `prometheus-node-exporter` endpoint protection using `kube-rbac-proxy`. By setting `kubeRBACProxy.enabled: true`, this chart will deploy a RBAC proxy container protecting the node-exporter endpoint. | ||||||
| To authorize access, authenticate your requests (via a `ServiceAccount` for example) with a `ClusterRole` attached such as: | ||||||
|
|
||||||
| ```yaml | ||||||
| apiVersion: rbac.authorization.k8s.io/v1 | ||||||
| kind: ClusterRole | ||||||
| metadata: | ||||||
| name: prometheus-node-exporter-read | ||||||
| rules: | ||||||
| - apiGroups: [ "" ] | ||||||
| resources: ["services/node-exporter-prometheus-node-exporter"] | ||||||
| verbs: | ||||||
| - get | ||||||
| ``` | ||||||
|
|
||||||
| See [kube-rbac-proxy examples](https://github.com/brancz/kube-rbac-proxy/tree/master/examples/resource-attributes) for more details. | ||||||
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,3 +13,17 @@ | |
| echo "Visit http://127.0.0.1:9100 to use your application" | ||
| kubectl port-forward --namespace {{ template "prometheus-node-exporter.namespace" . }} $POD_NAME 9100 | ||
| {{- end }} | ||
|
|
||
| {{- if .Values.kubeRBACProxy.enabled}} | ||
|
|
||
| kube-rbac-proxy endpoint protections is enabled: | ||
| - Metrics endpoints is now HTTPS | ||
| - Ensure that the client authenticates the requests (e.g. via service account) with the following role permissions: | ||
| ``` | ||
| rules: | ||
| - apiGroups: [ "" ] | ||
| resources: ["services/{{ template "prometheus-node-exporter.fullname" . }}"] | ||
| verbs: | ||
| - get | ||
| ``` | ||
| {{- end }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be a formatting error in the markdown link. The link tag is nested within itself, which may cause rendering issues in some markdown viewers.