Robot Upgrade: argo-cd chart upgrade from 8.1.0 to 9.1.4

[weizhoublue]

I am robot, upgrade: project argo-cd chart upgrade from 8.1.0 to 9.1.4

[gemini-code-assist]

Summary of Changes

Hello @weizhoublue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a significant upgrade of the Argo CD Helm chart from version 8.1.0 to 9.1.4, aligning with the Argo CD application version 3.2.0. The update introduces experimental Gateway API support for flexible ingress routing, enhances resource management with Vertical Pod Autoscaler for the application controller, and refines network policy configurations. It also includes critical dependency updates for Redis and Dex, alongside important CRD schema improvements for Application, ApplicationSet, and Project resources. Users should be aware of documented breaking changes related to configs.params and redis-ha when upgrading.

Highlights

• Argo CD Chart Upgrade: The main Argo CD Helm chart has been upgraded from version 8.1.0 to 9.1.4, bringing numerous updates and new features.
• Argo CD Application Version Bump: The underlying Argo CD application version has been updated from v3.0.6 to v3.2.0.
• Redis and Dex Image Updates: The Redis image tag has been updated from 7.2.8-alpine to 8.2.2-alpine, the Redis exporter from v1.74.0 to v1.80.1 (and v1.69.0 to v1.75.0 in the redis-ha subchart), and the Dex image from v2.43.1 to v2.44.0.
• Gateway API Support: New experimental support for Gateway API has been introduced, including HTTPRoute, GRPCRoute, and BackendTLSPolicy configurations for the Argo CD server, with corresponding documentation in the README.md.
• Vertical Pod Autoscaler (VPA) for Application Controller: A new Vertical Pod Autoscaler (VPA) configuration has been added for the application controller, allowing for automatic resource adjustments.
• Enhanced Network Policy Control: Network policy creation for various components (controller, repoServer, server, dex, redis, applicationSet, notifications, commitServer) can now be controlled more granularly via dedicated networkPolicy.create flags.
• Breaking Changes in v9.0.0 and v9.1.0: The README.md highlights breaking changes, including the removal of many parameters under .Values.configs.params and a change in the default value for applicationsetcontroller.policy. Additionally, a breaking change in redis-ha v9.1.0 requires manual intervention for argocd-redis-ha-haproxy deployment due to immutable selector label changes.
• CRD Schema Enhancements: Several Custom Resource Definition (CRD) schemas have been updated, adding new fields like refresh for retry strategies, minLength and pattern validations for paths, continueOnRepoNotFoundError, titleMatch for pull request generators, labels for GitHub generators, deletionOrder for rolling sync strategy, and resourcesCount in status for ApplicationSet, and maxLength for project description and description for sync windows in Project CRDs.
• New Deployment Labels and Environment Variables: New deploymentLabels fields have been added across various components for better labeling. Several new environment variables related to OCI manifest handling and sync wave delays have also been introduced.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request upgrades the argo-cd Helm chart from version 8.1.0 to 9.1.4, which is a significant update. The changes include version bumps for the chart and its dependencies, extensive documentation updates for new features and breaking changes, and numerous template modifications to support new functionalities like Gateway API and VPA. My review has identified a few issues, including a typo in a new VPA template that would break its functionality, a regression in the GKE ingress configuration that uses a deprecated annotation, and a broken link in the documentation. These issues should be addressed to ensure the chart's correctness and usability.

[gemini-code-assist]

There's a typo in annnotaions. It should be annotations. This will cause the annotations not to be applied.

  annotations:

[gemini-code-assist]

The kubernetes.io/ingress.class annotation is deprecated for Kubernetes versions 1.18 and later. Since this chart requires Kubernetes >=1.25.0-0, the ingressClassName field in the spec should be used instead. This change, along with the removal of spec.ingressClassName, is a regression and might cause issues with modern Ingress controllers.

[gemini-code-assist]

The link to the GitHub issue seems to be broken. It was a full URL and is now just #121, which won't resolve correctly. Please restore the full URL to make the documentation helpful for users.