Robot Upgrade: submariner-k8s-broker chart upgrade from 0.19.2 to 0.21.2

[weizhoublue]

I am robot, upgrade: project submariner-k8s-broker chart upgrade from 0.19.2 to 0.21.2

[gemini-code-assist]

Summary of Changes

Hello @weizhoublue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the upgrade of the submariner-k8s-broker Helm chart to version 0.21.2. The core of this update involves substantial revisions to the CustomResourceDefinitions (CRDs) to enhance their schemas, introduce new capabilities, and align with evolving API standards. Accompanying these CRD changes, the chart's internal structure has been refined by consolidating RBAC definitions and removing conditional resource creation, leading to a more robust and predictable deployment. This also simplifies the chart's external configuration by removing previously exposed values.yaml entries.

Highlights

• Chart Version Upgrade: The submariner-k8s-broker Helm chart has been upgraded from version 0.19.2 to 0.21.2 across all relevant configuration and metadata files.
• CRD Schema Enhancements: Significant updates have been applied to multiple CustomResourceDefinitions (CRDs), including endpoints.submariner.io, clusters.submariner.io, gateways.submariner.io, serviceexports.multicluster.x-k8s.io, and serviceimports.multicluster.x-k8s.io. These changes introduce new fields (e.g., healthCheckIPs, privateIPs, publicIPs), deprecate older ones (e.g., healthCheckIP, private_ip, public_ip), and refine schema definitions for improved API consistency and functionality. Notably, serviceexports and serviceimports CRDs now include more detailed status conditions and expanded IP list capacities.
• RBAC and Service Account Refactoring: The Helm chart's RBAC Role definition has been externalized into a new template file (_role.tpl), and the conditional creation logic for RBAC resources and service accounts has been removed. This ensures that these essential Kubernetes resources are always created by the chart, simplifying deployment and management.
• Configuration Simplification: Several configuration options related to RBAC, CRD creation, and service account naming (rbac.create, crd.create, serviceAccounts.client.create, serviceAccounts.client.name) have been removed from the values.yaml files. This streamlines the chart's external configuration interface, as these aspects are now implicitly managed by the chart's updated logic.
• Documentation Update: The 'Values' section, which previously detailed configurable parameters, has been removed from the README.md files within the chart structure. This suggests a shift in how chart values are documented or that these specific values are no longer directly exposed for configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request automates the upgrade of the submariner-k8s-broker Helm chart from version 0.19.2 to 0.21.2. The changes are extensive and include significant updates to CRDs to support new features like dual-stack networking and to align with newer Kubernetes API standards. The chart has also been simplified by removing several configuration options, making the installation of core components like CRDs and RBAC unconditional. This is a breaking change but simplifies chart maintenance and usage. The RBAC rules have been refactored and made more specific, improving security. Overall, the changes are positive and reflect a healthy evolution of the chart. I've added a few comments highlighting the breaking changes and suggesting improvements to documentation to make the upgrade path clearer for users.