Robot Upgrade: ingress-nginx chart upgrade from 4.13.2 to 4.14.0

[weizhoublue]

I am robot, upgrade: project ingress-nginx chart upgrade from 4.13.2 to 4.14.0

[gemini-code-assist]

Summary of Changes

Hello @weizhoublue, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request automates the upgrade of the ingress-nginx Helm chart from version 4.13.2 to 4.14.0. This routine update includes bumping the chart and controller image versions, introducing new configuration parameters for resource management and monitoring, and enhancing Helm templating capabilities for init containers and extra volumes. The changes also involve updating documentation and adding new changelog entries to reflect the version progression.

Highlights

• Chart Version Upgrade: The ingress-nginx Helm chart has been upgraded from version 4.13.2 to 4.14.0, along with its associated controller image from v1.13.2 to v1.14.0.
• New Configuration Options: New configurable options have been introduced, including resizePolicy for controller containers, volumeMounts and volumes for admission webhook jobs, and scrapeTimeout for the Prometheus ServiceMonitor.
• Helm Templating Support: The extraInitContainers and defaultBackend.extraVolumes now support Helm templating, allowing for more dynamic configurations.
• Changelog Updates: Several new changelog files have been added for intermediate versions (4.12.5, 4.12.6, 4.12.7, 4.12.8, 4.13.3, 4.13.4, 4.14.0) to provide a detailed history of changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request upgrades the ingress-nginx Helm chart from version 4.13.2 to 4.14.0. The update includes new image versions for the controller and webhook cert generator, introduces new features like resizePolicy for containers and scrapeTimeout for ServiceMonitors, and enhances flexibility by enabling Helm templating in more values. While most changes are correct, I've identified a significant issue with the implementation of the new resizePolicy feature, where an incorrect Kubernetes version check will prevent it from functioning as expected. I've also noted a minor issue in a newly added changelog file.

[gemini-code-assist]

The semverCompare check for resizePolicy is set to >=1.33.0-0. The "In-place Pod Resources Resize" feature, which introduces resizePolicy, graduated to Beta in Kubernetes v1.27. This check will prevent the feature from being used on supported Kubernetes versions (1.27+). It should be >=1.27.0-0.

        {{- if semverCompare ">=1.27.0-0" .Capabilities.KubeVersion.Version }}
        {{- if .Values.controller.resizePolicy }}
          resizePolicy: {{ toYaml .Values.controller.resizePolicy | nindent 12 }}
        {{- end }}
        {{- end }}

[gemini-code-assist]

The semverCompare check for resizePolicy is set to >=1.33.0-0. The "In-place Pod Resources Resize" feature, which introduces resizePolicy, graduated to Beta in Kubernetes v1.27. This check will prevent the feature from being used on supported Kubernetes versions (1.27+). It should be >=1.27.0-0.

        {{- if semverCompare ">=1.27.0-0" .Capabilities.KubeVersion.Version }}
        {{- if .Values.controller.resizePolicy }}
          resizePolicy: {{ toYaml .Values.controller.resizePolicy | nindent 12 }}
        {{- end }}
        {{- end }}

[gemini-code-assist]

The capabilities for this test should be updated to 1.27 to match the correct Kubernetes version for the resizePolicy feature.

    capabilities:
      majorVersion: 1
      minorVersion: 27

[gemini-code-assist]

The capabilities for this test should be updated to 1.27 to match the correct Kubernetes version for the resizePolicy feature.

    capabilities:
      majorVersion: 1
      minorVersion: 27

[gemini-code-assist]

The "Full Changelog" link points to a comparison of the same tag, which will always result in an empty diff. It should likely compare helm-chart-4.12.6 with helm-chart-4.12.7 to show the actual changes for this version.

Suggested change

	**Full Changelog**: https://github.com/kubernetes/ingress-nginx/compare/helm-chart-4.12.7...helm-chart-4.12.7
	**Full Changelog**: https://github.com/kubernetes/ingress-nginx/compare/helm-chart-4.12.6...helm-chart-4.12.7