-
Notifications
You must be signed in to change notification settings - Fork 29
Robot Upgrade: prometheus-adapter chart upgrade from 4.10.0 to 5.2.0 #3699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @weizhoublue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a significant upgrade of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request automates the upgrade of the prometheus-adapter Helm chart from version 4.10.0 to 5.2.0. The changes are comprehensive, including updates to the chart version, application version, removal of deprecated APIs like PodSecurityPolicy, and the introduction of new features and configuration options. Overall, the upgrade aligns with the upstream changes and is well-executed. I've identified a minor issue with a malformed markdown link in the README files that should be corrected.
| - Helm Repository: `https://prometheus-community.github.io/helm-charts` with chart `prometheus-adapter` | ||
|
|
||
| _See [`helm repo`](https://helm.sh/docs/helm/helm_repo/) for command documentation._ | ||
| The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown link for helm repo appears to be malformed. It's currently [helm repo]([helm repo](https://helm.sh/docs/helm/helm_repo/)), which will not render correctly. It should be corrected to [helm repo](https://helm.sh/docs/helm/helm_repo/).
| The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository. | |
| The installation instructions use the OCI registry. Refer to the [`helm repo`](https://helm.sh/docs/helm/helm_repo/) command documentation for information on installing charts via the traditional repository. |
| - Helm Repository: `https://prometheus-community.github.io/helm-charts` with chart `prometheus-adapter` | ||
|
|
||
| _See [`helm repo`](https://helm.sh/docs/helm/helm_repo/) for command documentation._ | ||
| The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown link for helm repo appears to be malformed. It's currently [helm repo]([helm repo](https://helm.sh/docs/helm/helm_repo/)), which will not render correctly. It should be corrected to [helm repo](https://helm.sh/docs/helm/helm_repo/).
| The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository. | |
| The installation instructions use the OCI registry. Refer to the [`helm repo`](https://helm.sh/docs/helm/helm_repo/) command documentation for information on installing charts via the traditional repository. |
a372cbf to
1a8cc0d
Compare
beb67c5 to
b0266ab
Compare
66c827c to
97f1c2e
Compare
82d598b to
8299602
Compare
7de48d0 to
e458452
Compare
f0c705b to
d37d1fe
Compare
214b8d8 to
5d4c490
Compare
Signed-off-by: robot <[email protected]>
5d4c490 to
a19aea9
Compare
I am robot, upgrade: project prometheus-adapter chart upgrade from 4.10.0 to 5.2.0