Skip to content

Conversation

@weizhoublue
Copy link
Member

I am robot, upgrade: project prometheus-adapter chart upgrade from 4.10.0 to 5.2.0

@gemini-code-assist
Copy link

Summary of Changes

Hello @weizhoublue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a significant upgrade of the prometheus-adapter Helm chart to version 5.2.0, bringing the application version to v0.12.0. This essential maintenance step ensures compatibility with modern Kubernetes environments by raising the minimum required Kubernetes version to 1.21+ and removing reliance on deprecated APIs like PodSecurityPolicy and policy/v1beta1 for PodDisruptionBudgets. The update also streamlines chart usage by introducing OCI artifact distribution and provides more granular control over deployment and certificate management through new configuration parameters.

Highlights

  • Prometheus Adapter Chart Upgrade: The Helm chart for prometheus-adapter has been upgraded from version 4.10.0 to 5.2.0, which also updates the underlying application version to v0.12.0.
  • Kubernetes Version Requirement Increased: The minimum required Kubernetes version for deploying the chart has been raised from 1.14+ to 1.21+.
  • Removal of Deprecated APIs: Support for the deprecated policy/v1beta1 API for PodDisruptionBudgets and PodSecurityPolicy resources has been removed, aligning the chart with current Kubernetes standards.
  • OCI Artifact Support and Documentation Updates: The README.md files have been updated to reflect the new Kubernetes version prerequisite and to include instructions for installing the chart via OCI Artifacts, alongside traditional Helm repositories.
  • Enhanced Configuration Options: New configuration parameters have been introduced for revisionHistoryLimit in deployments and cert-manager certificates, automountServiceAccountToken for service accounts, and unhealthyPodEvictionPolicy for PodDisruptionBudgets, offering more granular control.
  • Memory Query Refinement: Prometheus memory queries within the chart's configuration have been updated to utilize the round() function, potentially leading to more precise metric reporting.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request automates the upgrade of the prometheus-adapter Helm chart from version 4.10.0 to 5.2.0. The changes are comprehensive, including updates to the chart version, application version, removal of deprecated APIs like PodSecurityPolicy, and the introduction of new features and configuration options. Overall, the upgrade aligns with the upstream changes and is well-executed. I've identified a minor issue with a malformed markdown link in the README files that should be corrected.

- Helm Repository: `https://prometheus-community.github.io/helm-charts` with chart `prometheus-adapter`

_See [`helm repo`](https://helm.sh/docs/helm/helm_repo/) for command documentation._
The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The markdown link for helm repo appears to be malformed. It's currently [helm repo]([helm repo](https://helm.sh/docs/helm/helm_repo/)), which will not render correctly. It should be corrected to [helm repo](https://helm.sh/docs/helm/helm_repo/).

Suggested change
The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository.
The installation instructions use the OCI registry. Refer to the [`helm repo`](https://helm.sh/docs/helm/helm_repo/) command documentation for information on installing charts via the traditional repository.

- Helm Repository: `https://prometheus-community.github.io/helm-charts` with chart `prometheus-adapter`

_See [`helm repo`](https://helm.sh/docs/helm/helm_repo/) for command documentation._
The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The markdown link for helm repo appears to be malformed. It's currently [helm repo]([helm repo](https://helm.sh/docs/helm/helm_repo/)), which will not render correctly. It should be corrected to [helm repo](https://helm.sh/docs/helm/helm_repo/).

Suggested change
The installation instructions use the OCI registry. Refer to the [`helm repo`]([`helm repo`](https://helm.sh/docs/helm/helm_repo/)) command documentation for information on installing charts via the traditional repository.
The installation instructions use the OCI registry. Refer to the [`helm repo`](https://helm.sh/docs/helm/helm_repo/) command documentation for information on installing charts via the traditional repository.

@github-actions github-actions bot force-pushed the upgrade/prometheus-adapter/5.2.0 branch 7 times, most recently from a372cbf to 1a8cc0d Compare November 1, 2025 20:10
@github-actions github-actions bot force-pushed the upgrade/prometheus-adapter/5.2.0 branch 7 times, most recently from beb67c5 to b0266ab Compare November 8, 2025 20:10
@github-actions github-actions bot force-pushed the upgrade/prometheus-adapter/5.2.0 branch 7 times, most recently from 66c827c to 97f1c2e Compare November 15, 2025 20:11
@github-actions github-actions bot force-pushed the upgrade/prometheus-adapter/5.2.0 branch 4 times, most recently from 82d598b to 8299602 Compare November 19, 2025 20:12
@github-actions github-actions bot force-pushed the upgrade/prometheus-adapter/5.2.0 branch 8 times, most recently from 7de48d0 to e458452 Compare November 27, 2025 20:11
@github-actions github-actions bot force-pushed the upgrade/prometheus-adapter/5.2.0 branch 7 times, most recently from f0c705b to d37d1fe Compare December 4, 2025 20:12
@github-actions github-actions bot force-pushed the upgrade/prometheus-adapter/5.2.0 branch 5 times, most recently from 214b8d8 to 5d4c490 Compare December 9, 2025 20:12
@github-actions github-actions bot force-pushed the upgrade/prometheus-adapter/5.2.0 branch from 5d4c490 to a19aea9 Compare December 10, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants