fix: nan when m_i_new=-inf in online softmax #1948
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to resolve #1930.
Test
Environment: H800, CUDA 12.6
Warning
Sorry that I don't have access to newer architectures, on which I have to resort to other contributors to help test on.
FLASH_ATTN_CUDA_ARCHS="90" python setup.py installTest for the issue
Output:
Existing test