Update for simple beam fhicl in PDHD#204
Conversation
Angles and beam window position, taken from PDSP, needed to be adjusted.
|
Hi @calcuttj, @wenqiang-gu, just checking in—is the review ongoing for this PR? Thanks! |
|
trigger build |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
parent CI build details are available through the CI dashboard |
|
❌ CI build for DUNE Failed at phase ci_tests DUNE on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests DUNE phase logs parent CI build details are available through the CI dashboard |
|
trigger build |
|
I've been using this PR as a build trigger as the CLI build trigger hasn't been working -- sorry for the noise! |
|
✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard |
|
✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard |
|
parent CI build details are available through the CI dashboard |
|
❌ CI build for DUNE Failed at phase ci_tests DUNE on slf7 for e26:prof - ignored warnings for build -- details available through the CI dashboard 🚨 For more details about the failed phase, check the ci_tests DUNE phase logs parent CI build details are available through the CI dashboard |
|
Hi @lpaulucc, could you please confirm if this PR is still active? |
|
Hi @wyjang-uta . It is still waiting for a review unfortunately... |
|
@calcuttj Provided me with the values to update this fhicl. He should be able to review this PR. |
|
@calcuttj would you be able to check this PR? This file has been used in the simulations that were used as input for the X-arapuca efficiency in PDHD. The paper that contains this result is almost complete and it would be very much necessary to have a position on this. Thank you |
Angles and beam window position, taken from PDSP, needed to be adjusted.