Skip to content

Conversation

@gcrone
Copy link
Contributor

@gcrone gcrone commented Oct 20, 2025

@jcfreeman2 jcfreeman2 self-requested a review October 20, 2025 21:14
Copy link
Contributor

@jcfreeman2 jcfreeman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Clearly the one-line change does what it's supposed to do.

I've created a build using this PR as well as its associated PRs, CS2FD_DEV_251020_A9 (https://github.com/DUNE-DAQ/daq-release/actions/runs/18659788637) and integration tests all ran successfully (https://github.com/DUNE-DAQ/daq-release/actions/runs/18661336383).

For further context, please see DUNE-DAQ/daq-deliverables#198 and DUNE-DAQ/connectivityserver#24

@gcrone gcrone marked this pull request as ready for review October 21, 2025 14:39
@gcrone gcrone merged commit 3e447ac into develop Oct 21, 2025
4 checks passed
@gcrone gcrone deleted the gcrone/pytest branch October 21, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants