JCF: Issue #66: various DUNE DAQ Python standardizations, including m…#67
Closed
jcfreeman2 wants to merge 1 commit intodevelopfrom
Closed
JCF: Issue #66: various DUNE DAQ Python standardizations, including m…#67jcfreeman2 wants to merge 1 commit intodevelopfrom
jcfreeman2 wants to merge 1 commit intodevelopfrom
Conversation
…ove of Python (and related) code into src/druncschema; listing of dependencies without versions; and explicit listing of package version in the pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ove of Python (and related) code into
src/druncschema; listing of dependencies without versions; and explicit listing of package version in thepyproject.tomlDescription
Addresses issue #66
This brings the Python section of the package in line with the description in DUNE-DAQ/daq-deliverables#191
Fixes #66
Type of change
It's a "Breaking change" in the sense that developers will need to know to go into
src/druncschemafor the Python code.Key checklist
python -m pytest)pre-commit run --all-files)There are no tests written (so
python -m pytestjust announcesno tests ran) and whileruffstates:...that problem strikes me as outside the remit of a standardization of Python packaging.
Further checks
Code is commented, particularly in hard-to-understand areas
Tests added or an issue has been opened to tackle that in the future.
(Indicate issue here: # (issue))
As this PR doesn't involve code changes, neither of these checks is applicable here.