Skip to content

JCF: Issue #66: various DUNE DAQ Python standardizations, including m…#67

Closed
jcfreeman2 wants to merge 1 commit intodevelopfrom
johnfreeman/issue66_standardization
Closed

JCF: Issue #66: various DUNE DAQ Python standardizations, including m…#67
jcfreeman2 wants to merge 1 commit intodevelopfrom
johnfreeman/issue66_standardization

Conversation

@jcfreeman2
Copy link
Contributor

@jcfreeman2 jcfreeman2 commented Sep 23, 2025

…ove of Python (and related) code into src/druncschema; listing of dependencies without versions; and explicit listing of package version in the pyproject.toml

Description

Addresses issue #66

This brings the Python section of the package in line with the description in DUNE-DAQ/daq-deliverables#191

Fixes #66

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature (non-breaking change which adds functionality)
  • Optimization (non-breaking, back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)
  • [X ] Breaking change (whatever its nature)

It's a "Breaking change" in the sense that developers will need to know to go into src/druncschema for the Python code.

Key checklist

  • All tests pass (eg. python -m pytest)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

There are no tests written (so python -m pytest just announces no tests ran) and while ruff states:

src/druncschema/__init__.py:1:1: D104 Missing docstring in public package
src/druncschema/__init__.py:1:89: E501 Line too long (130 > 88)

...that problem strikes me as outside the remit of a standardization of Python packaging.

Further checks

  • Code is commented, particularly in hard-to-understand areas

  • Tests added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

    As this PR doesn't involve code changes, neither of these checks is applicable here.

…ove of Python (and related) code into src/druncschema; listing of dependencies without versions; and explicit listing of package version in the pyproject.toml
@jcfreeman2 jcfreeman2 closed this Nov 1, 2025
@jcfreeman2 jcfreeman2 deleted the johnfreeman/issue66_standardization branch November 1, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bring druncschema in line with current Python packaging standards if necessary

1 participant