Merged
Conversation
PawelPlesniak
approved these changes
Aug 5, 2025
Contributor
PawelPlesniak
left a comment
PawelPlesniak
left a comment
There was a problem hiding this comment.
LGTM
Tested with MSQT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves DUNE-DAQ/drunc#495.
This is the second in a series of changes replacing the generic Any-packed messages with dedicated ones. In this change, the ProcessManager is addressed. Took a bit longer than expected -- I wanted to be sure that I wasn't accidentally leaving something out. Might need a quick chat to step through the changes.
I am working on separating the 'drivers' out into separate classes, since caveats in each driver type make subclassing more messier than not. Even the gRPC stub classes are not covariant.
NB: As for which messages, I just used existing ones for now, and left deciding on a proper set of messages for later. Token can be omitted from these messages as we can pass this information in via metadata, as intended.