Proposal to increase the severity of the ConnSvc startup timeout message#757
Open
bieryAtFnal wants to merge 2 commits intodevelopfrom
Open
Proposal to increase the severity of the ConnSvc startup timeout message#757bieryAtFnal wants to merge 2 commits intodevelopfrom
bieryAtFnal wants to merge 2 commits intodevelopfrom
Conversation
…rver startup has timed out to be an error message instead of a debug messages (in client.py).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified the logging of the message that says that the ConnectivityServer startup has timed out to be an error message instead of a debug messages (in client.py).
Description
While I was working on the integtest in
daqsystemtestthat demonstrates the running of a small test system on multiple computers (sample_ehn1_multihost_test.py), I noticed that the integtest would fail the first time that I tried it with a new base release. I traced this to the slow loading of the new nightly release on the remote computers, but I needed to enable DEBUG messages indruncin order to discover what was happening.It would have been really great if there had been an error message that told me that the startup of the ConnectivityServer was timing out, and that was why
druncwas aborting the DAQ session.This PR suggests a change in message severity that I believe would help.
As an aside, I see that there is a
DruncSetupExceptionthrown when the ConnSvc startup times out, but I'm not seeing any console output that tells me that an exceptional condition was encountered indrunc. It simply closes down the DAQ session.Another side comment is that there doesn't seem to be a way to increase the ConnSvc startup timeout in the
drunccode. That is probably not critical, but it may be nice to have.To test this change, I locally modified the
druncprocess_manager_driverto use an artificially short timeout, as shown below. Without the change to the message severity covered in this PR,druncsimply closes down the session without telling us why it did so. With the change in message severity, it prints out a helpful message.Type of change
Further checks