Closed
Conversation
emmuhamm
commented
Jan 15, 2026
Comment on lines
+227
to
+229
| uid = self._ensure_one_process(matching_uuids, in_boot_request=True) | ||
| #! Thank you copilot. now why does this work?? | ||
| # Better yet, better understand why it has to be in boot request true here.. |
Contributor
Author
There was a problem hiding this comment.
Why does this work?
emmuhamm
commented
Jan 19, 2026
| elif len(uuids) > 1: | ||
| raise BadQuery("There are more than 1 processes corresponding to the query") | ||
|
|
||
| if in_boot_request: |
Contributor
Author
There was a problem hiding this comment.
What would be the use case for looking in the boot request?
| @@ -498,7 +498,7 @@ | |||
| else: | |||
| if uuids[0] not in self.process_store: | |||
Contributor
Author
There was a problem hiding this comment.
What would be the case for looking in the process_store?
Contributor
Author
|
Closed as it was made urgent fixed by #761 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #748
WIP
Please include a summary of the change and which issue is fixed (if any). Please also
include relevant motivation and context. List any dependencies that are required for
this change.
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))