Noting batch mode for exiting integ tests #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note - the |
Member
|
I tried starting |
Collaborator
Author
|
Thanks for this, the filter used for defining the error state currently only changes the root controller, and is something that is easily fixable. Will address this on Monday, but thank you for checking |
Collaborator
Author
|
This is interesting. I have run drunc-unified-shell ssh-standalone config/daqsystemtest/example-configs.data.xml local-1x1-config PawelIssueTesting boot conf wait 10 start --run-number 1 shutdown
...
[2025/09/10 14:54:31] INFO commands.py:53 controller.interface: Command wait running for 10 seconds.
[2025/09/10 14:54:32] ERROR sh.py:1717 process_manager.SSH_process_manager: Connection to localhost closed.
[2025/09/10 14:54:32] ERROR sh.py:1717 process_manager.SSH_process_manager: Connection to localhost closed.
[2025/09/10 14:54:32] ERROR sh.py:1717 process_manager.SSH_process_manager: Connection to localhost closed.
[2025/09/10 14:54:32] ERROR sh.py:1717 process_manager.SSH_process_manager: Connection to localhost closed.
[2025/09/10 14:54:32] ERROR sh.py:1717 process_manager.SSH_process_manager: Connection to localhost closed.
[2025/09/10 14:54:32] ERROR sh.py:1717 process_manager.SSH_process_manager: Connection to localhost closed.
[2025/09/10 14:54:32] ERROR sh.py:1717 process_manager.SSH_process_manager: Connection to localhost closed.
[2025/09/10 14:54:32] INFO ssh_process_manager.py:228 process_manager.SSH_process_manager: Process 'dfo-01' (session: 'PawelIssueTesting', user: 'pplesnia') process exited with exit code 143
[2025/09/10 14:54:32] INFO ssh_process_manager.py:228 process_manager.SSH_process_manager: Process 'hsi-fake-01' (session: 'PawelIssueTesting', user: 'pplesnia') process exited with exit code 143
[2025/09/10 14:54:32] ERROR sh.py:1717 process_manager.SSH_process_manager: Connection to localhost closed.
[2025/09/10 14:54:32] INFO ssh_process_manager.py:228 process_manager.SSH_process_manager: Process 'tp-stream-writer' (session: 'PawelIssueTesting', user: 'pplesnia') process exited with exit code 143
[2025/09/10 14:54:32] INFO ssh_process_manager.py:228 process_manager.SSH_process_manager: Process 'hsi-fake-to-tc-app' (session: 'PawelIssueTesting', user: 'pplesnia') process exited with exit code 143
[2025/09/10 14:54:32] INFO ssh_process_manager.py:228 process_manager.SSH_process_manager: Process 'tc-maker-1' (session: 'PawelIssueTesting', user: 'pplesnia') process exited with exit code 143
[2025/09/10 14:54:32] INFO ssh_process_manager.py:228 process_manager.SSH_process_manager: Process 'mlt' (session: 'PawelIssueTesting', user: 'pplesnia') process exited with exit code 143
[2025/09/10 14:54:32] INFO ssh_process_manager.py:228 process_manager.SSH_process_manager: Process 'df-01' (session: 'PawelIssueTesting', user: 'pplesnia') process exited with exit code 143
[2025/09/10 14:54:32] INFO ssh_process_manager.py:228 process_manager.SSH_process_manager: Process 'ru-01' (session: 'PawelIssueTesting', user: 'pplesnia') process exited with exit code 143
[2025/09/10 14:54:41] INFO commands.py:55 controller.interface: Command wait ran for 10 seconds.
[2025/09/10 14:54:41] INFO shell_utils.py:462 controller.shell_utils: Running transition 'start' on controller 'root-controller', targeting: 'root-controller'
[2025/09/10 14:54:41] CRITICAL shell_utils.py:466 controller.shell_utils: False
PawelIssueTesting status
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Name ┃ Info ┃ State ┃ Substate ┃ In error ┃ Included ┃ Endpoint ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ root-controller │ │ configured │ preparing-start │ No │ Yes │ grpc://10.73.136.36:38269 │
│ df-controller │ │ configured │ configured │ No │ Yes │ grpc://10.73.136.36:43615 │
│ df-01 │ │ configured │ idle │ Yes │ Yes │ rest://10.73.136.36:43879 │
│ dfo-01 │ │ configured │ idle │ Yes │ Yes │ rest://10.73.136.36:42839 │
│ tp-stream-writer │ │ configured │ idle │ Yes │ Yes │ rest://10.73.136.36:35985 │
│ hsi-fake-controller │ │ configured │ configured │ No │ Yes │ grpc://10.73.136.36:43231 │
│ hsi-fake-01 │ │ configured │ idle │ Yes │ Yes │ rest://10.73.136.36:35639 │
│ hsi-fake-to-tc-app │ │ configured │ idle │ Yes │ Yes │ rest://10.73.136.36:33367 │
│ ru-controller │ │ configured │ configured │ No │ Yes │ grpc://10.73.136.36:40569 │
│ ru-01 │ │ configured │ idle │ Yes │ Yes │ rest://10.73.136.36:59257 │
│ trg-controller │ │ configured │ configured │ No │ Yes │ grpc://10.73.136.36:36377 │
│ mlt │ │ configured │ idle │ Yes │ Yes │ rest://10.73.136.36:49567 │
│ tc-maker-1 │ │ configured │ idle │ Yes │ Yes │ rest://10.73.136.36:40613 │
PawelIssueTesting status
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Name ┃ Info ┃ State ┃ Substate ┃ In error ┃ Included ┃ Endpoint ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ root-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:38269 │
│ df-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:43615 │
│ df-01 │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:43879 │
│ dfo-01 │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:42839 │
│ tp-stream-writer │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:35985 │
│ hsi-fake-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:43231 │
│ hsi-fake-01 │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:35639 │
│ hsi-fake-to-tc-app │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:33367 │
│ ru-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:40569 │
│ ru-01 │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:59257 │
│ trg-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:36377 │
│ mlt │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:49567 │
│ tc-maker-1 │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:40613 │
└────────────────────────┴──────┴────────────┴───────────────┴──────────┴──────────┴───────────────────────────┘
Run Info
┌───────────────────────┬───────────────────────────────────────────────────────────┐
│ Run number │ 1 │
│ Run type │ TEST │
│ Start time │ 2025-09-10 14:54:41 │
│ Duration │ 0:00:00 │
│ Trigger rate │ 0.0000 Hz │
│ Data storage disabled │ False │
│ Config file │ oksconflibs:config/daqsystemtest/example-configs.data.xml │
│ Config ID │ local-1x1-config │
└───────────────────────┴───────────────────────────────────────────────────────────┘
Waiting for start to complete... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0% -:--:--
start execution report
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
┃ Name ┃ Command execution ┃ FSM transition ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
│ root-controller │ Executed Successfully │ Fsm Failed │
│ ru-controller │ Executed Successfully │ Fsm Failed │
│ ru-01 │ Drunc Exception Thrown │ NA │
│ hsi-fake-controller │ Executed Successfully │ Fsm Failed │
│ hsi-fake-01 │ Drunc Exception Thrown │ NA │
│ hsi-fake-to-tc-app │ Drunc Exception Thrown │ NA │
│ trg-controller │ Executed Successfully │ Fsm Failed │
│ tc-maker-1 │ Drunc Exception Thrown │ NA │
│ mlt │ Drunc Exception Thrown │ NA │
│ df-controller │ Executed Successfully │ Fsm Failed │
│ dfo-01 │ Drunc Exception Thrown │ NA │
│ tp-stream-writer │ Drunc Exception Thrown │ NA │
│ df-01 │ Drunc Exception Thrown │ NA │
└────────────────────────┴────────────────────────┴────────────────┘
PawelIssueTesting status
┏━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Name ┃ Info ┃ State ┃ Substate ┃ In error ┃ Included ┃ Endpoint ┃
┡━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ root-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:38269 │
│ df-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:43615 │
│ df-01 │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:43879 │
│ dfo-01 │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:42839 │
│ tp-stream-writer │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:35985 │
│ hsi-fake-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:43231 │
│ hsi-fake-01 │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:35639 │
│ hsi-fake-to-tc-app │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:33367 │
│ ru-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:40569 │
│ ru-01 │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:59257 │
│ trg-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:36377 │
│ mlt │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:49567 │
│ tc-maker-1 │ │ configured │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:40613 │
└────────────────────────┴──────┴────────────┴───────────────┴──────────┴──────────┴───────────────────────────┘
Run Info
┌───────────────────────┬───────────────────────────────────────────────────────────┐
│ Run number │ 1 │
│ Run type │ TEST │
│ Start time │ 2025-09-10 14:54:41 │
│ Duration │ 0:00:00 │
│ Trigger rate │ 0.0000 Hz │
│ Data storage disabled │ False │
│ Config file │ oksconflibs:config/daqsystemtest/example-configs.data.xml │
│ Config ID │ local-1x1-config │
└───────────────────────┴───────────────────────────────────────────────────────────┘
[2025/09/10 14:54:41] ERROR shell_utils.py:279 utils.ShellContext: FSM is in error (state: "ready"
sub_state: "ready"
in_error: true
included: true
run_info {
run_type: "TEST"
run_number: 1
run_time_at_start: 1757508881
run_config_file: "oksconflibs:config/daqsystemtest/example-configs.data.xml"
run_config_name: "local-1x1-config"
}
), not currently accepting new commands.
[2025/09/10 14:54:41] INFO shell_utils.py:13 unified_shell.shell_utils: Running sequence: ['disable-triggers', 'drain-dataflow', 'stop-trigger-sources', 'stop', 'scrap', 'terminate']
[2025/09/10 14:54:41] INFO shell_utils.py:33 unified_shell.shell_utils: Skipping command 'disable-triggers'
[2025/09/10 14:54:42] INFO shell_utils.py:36 unified_shell.shell_utils: Running command: 'drain-dataflow'
[2025/09/10 14:54:42] INFO shell_utils.py:462 controller.shell_utils: Running transition 'drain_dataflow' on controller 'root-controller', targeting: 'root-controller'
[2025/09/10 14:54:42] CRITICAL shell_utils.py:466 controller.shell_utils: True
[2025/09/10 14:54:42] ERROR shell_utils.py:469 controller.shell_utils: Running in batch mode, and because error state is detected, exiting.
[2025/09/10 14:54:42] INFO shell.py:252 unified_shell: Retracting the session PawelIssueTesting from the connectivity service
[2025/09/10 14:54:42] INFO shell.py:375 unified_shell: Exiting unified_shell
[2025/09/10 14:54:42] INFO shell.py:377 unified_shell: unified_shell exited successfully. Investigating why MSQT did not follow now |
Collaborator
Author
|
Running the [2025/09/10 15:06:27] INFO commands.py:53 controller.interface: Command wait running for 20 seconds.
[2025/09/10 15:06:28] ERROR sh.py:1717 process_manager.SSH_process_manager: Connection to localhost closed.
[2025/09/10 15:06:28] ERROR sh.py:1717 process_manager.SSH_process_manager: Connection to localhost closed.
[2025/09/10 15:06:28] ERROR sh.py:1717 process_manager.SSH_process_manager: Connection to localhost closed.
[2025/09/10 15:06:28] ERROR sh.py:1717 process_manager.SSH_process_manager: Connection to localhost closed.
[2025/09/10 15:06:28] INFO ssh_process_manager.py:228 process_manager.SSH_process_manager: Process 'ru-det-conn-0' (session: 'minimal', user: 'pplesnia') process exited with exit code 143
[2025/09/10 15:06:28] INFO ssh_process_manager.py:228 process_manager.SSH_process_manager: Process 'df-01' (session: 'minimal', user: 'pplesnia') process exited with exit code 143
[2025/09/10 15:06:28] INFO ssh_process_manager.py:228 process_manager.SSH_process_manager: Process 'dfo-01' (session: 'minimal', user: 'pplesnia') process exited with exit code 143
[2025/09/10 15:06:28] INFO ssh_process_manager.py:228 process_manager.SSH_process_manager: Process 'mlt' (session: 'minimal', user: 'pplesnia') process exited with exit code 143
[2025/09/10 15:06:47] INFO commands.py:55 controller.interface: Command wait ran for 20 seconds.
[2025/09/10 15:06:47] INFO shell_utils.py:462 controller.shell_utils: Running transition 'disable_triggers' on controller 'root-controller', targeting: 'root-controller'
[2025/09/10 15:06:47] CRITICAL shell_utils.py:466 controller.shell_utils: False
minimal status
┏━━━━━━━━━━━━━━━━━━━┳━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Name ┃ Info ┃ State ┃ Substate ┃ In error ┃ Included ┃ Endpoint ┃
┡━━━━━━━━━━━━━━━━━━━╇━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ root-controller │ │ running │ disable_triggers-ready │ No │ Yes │ grpc://10.73.136.36:38323 │
│ df-controller │ │ running │ running │ No │ Yes │ grpc://10.73.136.36:40523 │
│ df-01 │ │ running │ idle │ Yes │ Yes │ rest://10.73.136.36:34171 │
│ dfo-01 │ │ running │ idle │ Yes │ Yes │ rest://10.73.136.36:52553 │
│ ru-controller │ │ running │ running │ No │ Yes │ grpc://10.73.136.36:37867 │
minimal status
┏━━━━━━━━━━━━━━━━━━━┳━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Name ┃ Info ┃ State ┃ Substate ┃ In error ┃ Included ┃ Endpoint ┃
┡━━━━━━━━━━━━━━━━━━━╇━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ root-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:38323 │
│ df-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:40523 │
│ df-01 │ │ running │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:34171 │
│ dfo-01 │ │ running │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:52553 │
│ ru-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:37867 │
│ ru-det-conn-0 │ │ running │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:51589 │
│ trg-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:34379 │
│ mlt │ │ running │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:34525 │
└───────────────────┴──────┴─────────┴───────────────┴──────────┴──────────┴───────────────────────────┘
Run Info
┌───────────────────────┬──────────────────────────────────────────────────────────────────────────────────────────┐
│ Run number │ 101 │
│ Run type │ TEST │
│ Start time │ 2025-09-10 15:06:25 │
│ Duration │ 0:00:22 │
│ Trigger rate │ 0.0000 Hz │
│ Data storage disabled │ False │
│ Config file │ oksconflibs:/tmp/pytest-of-pplesnia/pytest-7/config0/integtest-session-resolved.data.xml │
│ Config ID │ minimal │
└───────────────────────┴──────────────────────────────────────────────────────────────────────────────────────────┘
Waiting for disable_triggers to complete... ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 0% -:--:--
disable_triggers execution report
┏━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━┓
┃ Name ┃ Command execution ┃ FSM transition ┃
┡━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━┩
│ root-controller │ Executed Successfully │ Fsm Failed │
│ trg-controller │ Executed Successfully │ Fsm Failed │
│ mlt │ Drunc Exception Thrown │ NA │
│ ru-controller │ Executed Successfully │ Fsm Failed │
│ ru-det-conn-0 │ Drunc Exception Thrown │ NA │
│ df-controller │ Executed Successfully │ Fsm Failed │
│ dfo-01 │ Drunc Exception Thrown │ NA │
│ df-01 │ Drunc Exception Thrown │ NA │
└───────────────────┴────────────────────────┴────────────────┘
minimal status
┏━━━━━━━━━━━━━━━━━━━┳━━━━━━┳━━━━━━━━━┳━━━━━━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━━━━━━━━━━┓
┃ Name ┃ Info ┃ State ┃ Substate ┃ In error ┃ Included ┃ Endpoint ┃
┡━━━━━━━━━━━━━━━━━━━╇━━━━━━╇━━━━━━━━━╇━━━━━━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━━━━━━━━━━┩
│ root-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:38323 │
│ df-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:40523 │
│ df-01 │ │ running │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:34171 │
│ dfo-01 │ │ running │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:52553 │
│ ru-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:37867 │
│ ru-det-conn-0 │ │ running │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:51589 │
│ trg-controller │ │ ready │ ready │ Yes │ Yes │ grpc://10.73.136.36:34379 │
│ mlt │ │ running │ executing_cmd │ Yes │ Yes │ rest://10.73.136.36:34525 │
└───────────────────┴──────┴─────────┴───────────────┴──────────┴──────────┴───────────────────────────┘
Run Info
┌───────────────────────┬──────────────────────────────────────────────────────────────────────────────────────────┐
│ Run number │ 101 │
│ Run type │ TEST │
│ Start time │ 2025-09-10 15:06:25 │
│ Duration │ 0:00:22 │
│ Trigger rate │ 0.0000 Hz │
│ Data storage disabled │ False │
│ Config file │ oksconflibs:/tmp/pytest-of-pplesnia/pytest-7/config0/integtest-session-resolved.data.xml │
│ Config ID │ minimal │
└───────────────────────┴──────────────────────────────────────────────────────────────────────────────────────────┘
[2025/09/10 15:06:47] ERROR shell_utils.py:279 utils.ShellContext: FSM is in error (state: "ready"
sub_state: "ready"
in_error: true
included: true
run_info {
run_type: "TEST"
run_number: 101
run_time_at_start: 1757509585
run_time_since_start: 22
run_config_file: "oksconflibs:/tmp/pytest-of-pplesnia/pytest-7/config0/integtest-session-resolved.data.xml"
run_config_name: "minimal"
}
), not currently accepting new commands.
[2025/09/10 15:06:47] INFO commands.py:53 controller.interface: Command wait running for 2 seconds.
[2025/09/10 15:06:49] INFO commands.py:55 controller.interface: Command wait ran for 2 seconds.
[2025/09/10 15:06:49] INFO shell_utils.py:462 controller.shell_utils: Running transition 'drain_dataflow' on controller 'root-controller', targeting: 'root-controller'
[2025/09/10 15:06:49] CRITICAL shell_utils.py:466 controller.shell_utils: True
[2025/09/10 15:06:49] ERROR shell_utils.py:469 controller.shell_utils: Running in batch mode, and because error state is detected, exiting.
[2025/09/10 15:06:49] INFO shell.py:252 unified_shell: Retracting the session minimal from the connectivity service
[2025/09/10 15:06:49] WARNING client.py:111 utils.ConnectivityServiceClient: Session minimal not found on the connectivity service
[2025/09/10 15:06:49] INFO shell.py:375 unified_shell: Exiting unified_shell
[2025/09/10 15:06:49] INFO shell.py:377 unified_shell: unified_shell exited successfully. with |
Collaborator
Author
|
Killing everything on Going through |
eflumerf
approved these changes
Sep 10, 2025
Member
eflumerf
left a comment
eflumerf
left a comment
There was a problem hiding this comment.
Looks good for now, more detailed error handling and recovery to be discussed
jcfreeman2
pushed a commit
to DUNE-DAQ/daq-release
that referenced
this pull request
Sep 10, 2025
Contributor
|
The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires DUNE-DAQ/druncschema#65
Addresses #249
Addresses #297
Batch mode is managed "under the hood" by click context, but not directly by drunc. Therefore, when sending a batched set of commands e.g.
boot conf ps, when an error state is raised the batch is not stopped. This adds a catch to ensure that when an error state is reached, we do not continue with the test.Fixes #249
Type of change
Key checklist
python -m pytest)pre-commit run --all-files)Further checks
(Indicate issue here: # (issue))