SessMan: dedicated gRPC message types#485
Merged
PawelPlesniak merged 10 commits intodevelopfrom Jul 23, 2025
Merged
Conversation
Collaborator
|
This looks good, but just to clarify the |
Contributor
Author
|
Correct. Ed. Well actually I will use the same |
Collaborator
|
Tested by running a |
PawelPlesniak
approved these changes
Jul 23, 2025
Collaborator
PawelPlesniak
left a comment
There was a problem hiding this comment.
Tested manually
Also passed MSQT, although is independent of tests ran there
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves DUNE-DAQ/drunc_ui#496
This is the first in a series of changes which will replace the existing generic gRPC messages (arbitrary data packed to any) to a simpler and more reliable system of purpose-built gRPC messages.
This first PR starts with the Session Manager. Next will come Process Manager and then Controller. There is a sister PR in the druncschema repository required to run this (DUNE-DAQ/druncschema#58).
One can test by running
describe,list_all_sessionsandlist_all_configson a connected Session Manager driver.Benefits:
Any-type packing and unpacking. This is inefficient and hard to follow.