Properly set TC readout window sizes for daqsystemtest after updates in config#279
Open
wesketchum wants to merge 11 commits intodevelopfrom
Open
Properly set TC readout window sizes for daqsystemtest after updates in config#279wesketchum wants to merge 11 commits intodevelopfrom
wesketchum wants to merge 11 commits intodevelopfrom
Conversation
RandomTCMaker conf updated
Revert "RandomTCMaker conf updated"
This reverts commit 97aa623.
…systemtest into wketchum_revertrevert
13 tasks
…chum/FixTCReadoutWindow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some integtests in daqsystemtest were failing with the new RandomTriggerCandidateMaker updates (see here, including examples of tests that were failing). This PR tries to set the configuration for readout windows back to as it was before, so that the tests should all pass.
Should be testable by running through integtests and seeing they pass...
Type of change
Testing checklist
dbt-build --unittest)pytest -s minimal_system_quick_test.py)daqsystemtest_integtest_bundle.sh)python -m pytest)pre-commit run --all-files)Further checks
dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)(Indicate issue here: # (issue))