Skip to content

Properly set TC readout window sizes for daqsystemtest after updates in config#279

Open
wesketchum wants to merge 11 commits intodevelopfrom
wketchum/FixTCReadoutWindow
Open

Properly set TC readout window sizes for daqsystemtest after updates in config#279
wesketchum wants to merge 11 commits intodevelopfrom
wketchum/FixTCReadoutWindow

Conversation

@wesketchum
Copy link
Contributor

Description

Some integtests in daqsystemtest were failing with the new RandomTriggerCandidateMaker updates (see here, including examples of tests that were failing). This PR tries to set the configuration for readout windows back to as it was before, so that the tests should all pass.

Should be testable by running through integtests and seeing they pass...

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

Copy link
Contributor

@alessandrothea alessandrothea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants