Skip to content

Conversation

@emmuhamm
Copy link
Contributor

@emmuhamm emmuhamm commented Feb 12, 2026

Description

Screenshot 2026-02-12 at 13 46 38

split off #46

Fix #43

Fix #39

WILL ALSO NEED TO FIX IN THIS MINOR COMMENT LINKED BELOW FROM #46

We also need one where a warning is thrown when this happens:

log = get_logger("name", stream_handler = True)

new_log = get_logger("name") # Will grab the correct logger

new_log_extra = get_logger("name", stream_handler=True, rich_handler=True) # this will get the correct logger, but not add the rich handler. This should be checked when performing this function and be made explicit..


If full decription and testing details are included on a parent issue, please link to that here.
See issue # for details

Otherwise, please include a summary of the change and which issue is fixed (if any).
Include relevant motivation and context, including a target environment and dunedaq version if known.
Also list any dependencies that are required for this change.

Addresses issue #

Please also include instructions for how a reviewer can test your changes.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@emmuhamm emmuhamm force-pushed the emmuhamm/add-docs-pytest branch from fa66ba1 to 2e4fee1 Compare February 12, 2026 14:19
@emmuhamm emmuhamm force-pushed the emmuhamm/add-docs-pytest branch from 2e4fee1 to c1eb21c Compare February 12, 2026 14:22
@emmuhamm emmuhamm force-pushed the emmuhamm/add-docs-pytest branch from 48c46b2 to b912d37 Compare February 12, 2026 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Doc]: Provide documentation [Feature]: Unit tests for logging/ers

1 participant