Merged
Conversation
…o amogan/add_arguments_to_dbt_test_script
…o amogan/add_arguments_to_dbt_test_script
Collaborator
|
I like this idea. Two comments about what's on the feature branch:
|
Collaborator
|
I see my concerns are addressed here, so approved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
test_daq-buildtools.shwith a particular release ordaq-buildtoolsbranch name, I found it a little cumbersome to manually change the correct lines intest_daq-buildtools.sh. This PR adds--release,--dbt-branchand--repoas optional command line arguments with sensible defaults.Example:
./test_daq-buildtools.sh --release NFD_DEV_260201_A9 \ --dbt-branch johnfreeman/issue331_handle_deleted_repo \ --repo hdf5libs