Skip to content

Add arguments to dbt test script#527

Merged
andrewmogan merged 9 commits intodevelopfrom
amogan/add_arguments_to_dbt_test_script
Feb 10, 2026
Merged

Add arguments to dbt test script#527
andrewmogan merged 9 commits intodevelopfrom
amogan/add_arguments_to_dbt_test_script

Conversation

@andrewmogan
Copy link
Collaborator

When running test_daq-buildtools.sh with a particular release or daq-buildtools branch name, I found it a little cumbersome to manually change the correct lines in test_daq-buildtools.sh. This PR adds --release, --dbt-branch and --repo as optional command line arguments with sensible defaults.

Example:

./test_daq-buildtools.sh --release NFD_DEV_260201_A9 \
                         --dbt-branch johnfreeman/issue331_handle_deleted_repo \
                         --repo hdf5libs

@jcfreeman2
Copy link
Collaborator

I like this idea. Two comments about what's on the feature branch:

  • Concerning l. 81 of test_daq-buildtools.sh, source ~/daq-buildtools/env.sh - is there a guarantee that this daq-buildtools repo will be the one which the script cloned?
  • When I ran ./scripts/test_daq-buildtools.sh --release fddaq-v5.5.0-a9 --dbt-branch amogan/add_print_statements --repo snbmodules, I got ERROR: [02/09/26 16:16:08] [dbt-setup-release.sh:111]: Release path '/cvmfs/dunedaq-development.opensciencegrid.org/nightly/fddaq-v5.5.0-a9' does not exist. Note that you need to pass "-n" for a nightly build. Exiting... "

@jcfreeman2
Copy link
Collaborator

I see my concerns are addressed here, so approved.

@andrewmogan andrewmogan merged commit 992ef6f into develop Feb 10, 2026
@andrewmogan andrewmogan deleted the amogan/add_arguments_to_dbt_test_script branch February 10, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants