Skip to content

Move deps to venv so they are more clearly tracked#26

Merged
jcpunk merged 2 commits intodevelopfrom
venv
Jan 8, 2026
Merged

Move deps to venv so they are more clearly tracked#26
jcpunk merged 2 commits intodevelopfrom
venv

Conversation

@jcpunk
Copy link
Contributor

@jcpunk jcpunk commented Dec 31, 2025

Description

This sets up a python venv so you can easily inspect what was installed with pip

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (daqsystemtest_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@jcpunk jcpunk requested a review from eflumerf December 31, 2025 16:22
@jcpunk
Copy link
Contributor Author

jcpunk commented Dec 31, 2025

There should probably also be some labels attached to the container. There doesn't seem to be a large consensus on what labels are best out in the wild.

@jcpunk jcpunk merged commit dd3aa2c into develop Jan 8, 2026
@jcpunk jcpunk deleted the venv branch January 8, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants