CICD: Move OWNERS to .github/CODEOWNERS#3983
Conversation
|
Hello friend! Github is complaining that the people in CODEOWNERS do not have write permission. Each one gets an error such as: They don't have write permission because the current policy (from my employer) is that I have to approve any merge to main. Is there some other way to comply with the policy but give people write access? |
Howdy sir! 🙇
Oh dear, github policy and stackexchange policy are not playing nicely together here. 😭 Changing the policies is not a practical option. Effectively this means that the
Would adding the comment be enough to make this PR worth landing? I'm happy to work on the other github actions in this PR or a new one. |
|
This is unblocked now that we're in the new github org. 😄 |
dec9067 to
8d93d28
Compare
|
I rebased and fixed the one issue @cafferata noticed. I don't think I caused any of the CI jobs failing. How does it look now? |
CI Failure AnalysisAll 7 failing checks share a single root cause:
The fix is straightforward: run |
|
I would advise keeping |
Sounds good to me. I'd prefer to keep the PRs more focused and not glom unrelated changes onto them just so we can fix the GHAs. I think this is ready for review again. 😁 |
|
Suggestion: Once we merge this, we should create a new "role" called "provider" which has just enough privs to update labels and be a reviewer. (I assume that's possible.) However they shouldn't have merge privs. (I should be the only one that can merge to main for now) |
100% agree. This is exactly what I was hoping for. |
|
FYI: #4242 should fix the |
Signed-off-by: Christopher Hicks <chicks.net@gmail.com>
Signed-off-by: Christopher Hicks <chicks.net@gmail.com>
Signed-off-by: Christopher Hicks <chicks.net@gmail.com>
70f68b8 to
50b24f1
Compare
Summary
Fixes #3978
GitHub requires the CODEOWNERS file to be located in the
.github/directory (or repository root with that exact name) to function properly. This PR movesOWNERSto.github/CODEOWNERSand updates all references throughout the codebase.Changes Made
OWNERS→.github/CODEOWNERS.gitattributesto reference the new locationbuild/generate/ownersFile.goto generate the file in the correct locationwriting-providers.mdto reference.github/CODEOWNERSTest Plan
/bin/generate-all.shto verify the generator creates the file in the new location🤖 Generated with Claude Code