Skip to content

Several improvements to build efficiency#800

Merged
david-poindexter merged 1 commit into
DNNCommunity:mainfrom
valadas:build-performance
May 6, 2026
Merged

Several improvements to build efficiency#800
david-poindexter merged 1 commit into
DNNCommunity:mainfrom
valadas:build-performance

Conversation

@valadas

@valadas valadas commented May 6, 2026

Copy link
Copy Markdown
Member
  • Add .env.example and update README for local token config
  • Add ValidateGitHubToken target to check token validity/scope
  • Auto-set SKIP_CONTRIBUTORS if token missing/invalid
  • Allow Serve port configuration with auto-increment
  • Standardize plugin logging with Docfx.Common.Logger
  • Refactor GitHubApi to derive contributor stats from commits
  • Enhance contributor model with commit count and date
  • Refactor RepoStatsBuildStep and PageStatsBuildStep for clarity

We ran into a rate limit recently and I dound a couple of inneficiencies basically. This PR should make the build faster and use less Github API calls.

  • Update build.schema.json for new params and targets
  • Improve error handling and code consistency throughout

- Add .env.example and update README for local token config
- Add ValidateGitHubToken target to check token validity/scope
- Auto-set SKIP_CONTRIBUTORS if token missing/invalid
- Allow Serve port configuration with auto-increment
- Standardize plugin logging with Docfx.Common.Logger
- Refactor GitHubApi to derive contributor stats from commits
- Enhance contributor model with commit count and date
- Refactor RepoStatsBuildStep and PageStatsBuildStep for clarity

We ran into a rate limit recently and I dound a couple of inneficiencies basically. This PR should make the build faster and use less Github API calls.
- Update build.schema.json for new params and targets
- Improve error handling and code consistency throughout
@valadas valadas added the build label May 6, 2026
@valadas

valadas commented May 6, 2026

Copy link
Copy Markdown
Member Author

@david-poindexter @bdukes does anything in here stick out to you guys? I ran a full local build which worked fine using a PAT and in CI it should work the same but with a Github actions token (in theory). No real way to really test it without merging it though...

@valadas valadas requested review from bdukes and david-poindexter May 6, 2026 18:21

@bdukes bdukes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

@david-poindexter david-poindexter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me as well @valadas - thanks for the work on this! 🎉

@david-poindexter david-poindexter merged commit c26d89a into DNNCommunity:main May 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants