1.4 Add opaque to FINISH/PSK_FINISH #3150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
force-pushed
the
finish_opaque
branch
4 times, most recently
from
7a2deec to
c0876d4
Compare
Why does this need PQC? Opaque data should be completely independent of that. |
| @@ -603,8 +674,15 @@ libspdm_return_t libspdm_get_response_finish(libspdm_context_t *spdm_context, si | |||
| spdm_response->header.param1 = 0; | |||
| spdm_response->header.param2 = 0; | |||
|
|
|||
| ptr = (uint8_t *)spdm_response + sizeof(spdm_finish_response_t); | |||
| if (libspdm_get_connection_version(spdm_context) >= SPDM_MESSAGE_VERSION_14) { | |||
There was a problem hiding this comment.
Why doesn't the Responder generate opaque data?
There was a problem hiding this comment.
No OpaqueData is required in FINISH by SPDM spec. It is same as today. No additional device specific OpaqueData is required in KEY_EXCHANGE.
This is for future Auth Spec.
The new OpaqueData handling will be addressed in #2936
This does not need PQC, but this does need SPDM 1.4. |
jyao1
force-pushed
the
finish_opaque
branch
2 times, most recently
from
b109570 to
56977b2
Compare
Signed-off-by: Jiewen Yao <[email protected]>
Signed-off-by: Jiewen Yao <[email protected]>
Signed-off-by: Jiewen Yao <[email protected]>
Signed-off-by: Jiewen Yao <[email protected]>
Signed-off-by: Jiewen Yao <[email protected]>
steven-bellock
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3130
NOTE: This PR is based on #3129.