Skip to content

Autodetect ARCH if not set #3148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Autodetect ARCH if not set #3148

wants to merge 1 commit into from

Conversation

manojkiraneda
Copy link
Contributor

For native build, we should automatically detect the architecture rather than forcing users to provide that. ARCH is probably meant for cross compilation.

@steven-bellock
Copy link
Contributor

This will need logic to convert from the operating system's name to libspdm's. For example, CMAKE_HOST_SYSTEM_PROCESSOR is amd64 on a Windows PC. See https://cmake.org/cmake/help/latest/variable/CMAKE_HOST_SYSTEM_PROCESSOR.html.

@manojkiraneda
Autodetect ARCH if not set
50adca3 
For native build, we should automatically detect the architecture
rather than forcing users to provide that. ARCH is probably meant
for cross compilation.

Signed-off-by: Manojkiran Eda <[email protected]>
@manojkiraneda
Copy link
Contributor Author

manojkiraneda commented Jul 28, 2025 •
edited
Loading

This will need logic to convert from the operating system's name to libspdm's. For example, CMAKE_HOST_SYSTEM_PROCESSOR is amd64 on a Windows PC. See https://cmake.org/cmake/help/latest/variable/CMAKE_HOST_SYSTEM_PROCESSOR.html.

sure, I have added the mapping for windows specific ones in the latest push. Shall we drop the ARCH from all the CI infrastructure and see if we were able to obtain the ARCH automatically ? Do you guys think that would be a more comprehensive test to see if this patch works ?

@steven-bellock
Copy link
Contributor

Maybe remove arch from

since those are always Linux / x64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyao1 jyao1 Awaiting requested review from jyao1 jyao1 is a code owner

@steven-bellock steven-bellock Awaiting requested review from steven-bellock steven-bellock is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manojkiraneda @steven-bellock