Skip to content

Improvement: Move CAD management to t8_cad_handle with cmesh ownership - #2093

Merged
sandro-elsweijer merged 8 commits into
mainfrom
improvement-cad_handler
Mar 11, 2026
Merged

sandro-elsweijer merged 8 commits into
mainfrom
improvement-cad_handler

Conversation

@Lena-Richter

@Lena-Richter Lena-Richter commented Jan 14, 2026 •

Copy link
Copy Markdown
Collaborator

Closes #2218

Describe your changes here:

Changing t8_cad to t8_cad_handle for a more explicit CAD shape management. The cmesh now owns the CAD handle and uses a reference counter to manage it.
Also, the t8_geom prefix was removed for everything related to CAD shape management for cleanup. The mesh reader and geometry implementations were updated to support this new handle system.

All these boxes must be checked by the AUTHOR before requesting review:

  • The PR is small enough to be reviewed easily. If not, consider splitting up the changes in multiple PRs.
  • The title starts with one of the following prefixes: Documentation:, Bugfix:, Feature:, Improvement: or Other:.
  • If the PR is related to an issue, make sure to link it.
  • The author made sure that, as a reviewer, he/she would check all boxes below.

All these boxes must be checked by the REVIEWERS before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually.
  • The code follows the t8code coding guidelines.
  • New source/header files are properly added to the CMake files.
  • The code is well documented. In particular, all function declarations, structs/classes and their members have a proper doxygen documentation. Make sure to add a file documentation for each file!
  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue).

Tests

  • The code is covered in an existing or new test case using Google Test.
  • The code coverage of the project (reported in the CI) should not decrease. If coverage is decreased, make sure that this is reasonable and acceptable.
  • Valgrind doesn't find any bugs in the new code. This script can be used to check for errors; see also this wiki article.

If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

  • Should this use case be added to the github action?
  • If not, does the specific use case compile and all tests pass (check manually).

Scripts and Wiki

  • If a new directory with source files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example or tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one).

@Lena-Richter
Lena-Richter marked this pull request as ready for review January 19, 2026 08:11
@Lena-Richter
Lena-Richter marked this pull request as draft January 19, 2026 09:12
@Lena-Richter Lena-Richter changed the title Improvement: Rename t8_cad to t8_cad_handle Improvement: Move CAD management to t8_cad_handle with cmesh ownership Jan 19, 2026
@Lena-Richter
Lena-Richter marked this pull request as ready for review January 19, 2026 12:19
Comment thread src/t8_cad_handle/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad_handle/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad_handle/t8_cad_handle.hxx Outdated
Comment thread src/t8_cad_handle/t8_cad_handle.hxx Outdated
Comment thread src/t8_cad_handle/t8_cad_handle.hxx Outdated
Comment thread src/t8_cad_handle/t8_cad_handle.hxx Outdated
Comment thread src/t8_cad_handle/t8_cad_handle.hxx Outdated
Comment thread src/t8_cad_handle/t8_cad_handle.hxx Outdated
Comment thread src/t8_cad_handle/t8_cad_handle.hxx Outdated
Comment thread src/t8_cad_handle/t8_cad_handle.hxx Outdated
@codecov

codecov Bot commented Feb 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.25%. Comparing base (322342b) to head (cb0c420).
⚠️ Report is 207 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2093      +/-   ##
==========================================
+ Coverage   77.97%   78.25%   +0.27%     
==========================================
  Files         113      114       +1     
  Lines       19106    19050      -56     
==========================================
+ Hits        14898    14907       +9     
+ Misses       4208     4143      -65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/t8_cad/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad/t8_cad_handle.cxx
Comment thread src/t8_cad/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad/t8_cad_handle.cxx Outdated
Comment thread src/t8_cad/t8_cad_handle.cxx Outdated
@Lena-Richter Lena-Richter removed their assignment Feb 23, 2026
@sandro-elsweijer
sandro-elsweijer added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit a759367 Mar 11, 2026
26 checks passed
@sandro-elsweijer
sandro-elsweijer deleted the improvement-cad_handler branch March 11, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improvement: Move CAD management to t8_cad_handle with cmesh ownership

2 participants