fix!: migrate from httpx to httpx2#48
Merged
Merged
Conversation
httpx is dormant; pydantic has taken over maintenance under the httpx2 name. Swap the dependency and all imports/usages accordingly, following the same approach DIRACGrid/diracx used in #948. Closes DIRACGrid#46
Member
|
I would go with |
Contributor
Author
|
Should |
BREAKING CHANGE: Client and AsyncClient now accept max_connections instead of httpx_max_connections. The httpx_ prefix leaked an implementation detail that isn't meaningful to callers.
|
What's going to happen is that once this PR is merged, At this point, we will need to make the same adjustment in diracx as part of the renovate PR I would say |
|
To inform consumers we are introducing a breaking change, we should use the |
aldbr
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
httpx2name (https://github.com/pydantic/httpx2)httpxdependency forhttpx2and update all imports/usages (httpx.Client,httpx.AsyncClient,httpx.Response,httpx.HTTPError, etc.) acrosssrc/,tests/, andbenchmark_tests/Breaking change
Client/AsyncClientconstructor kwarghttpx_max_connectionstomax_connections.Closes #46