PAE - 159 setup stubs organisation registration accreditation #58
Conversation
There was a problem hiding this comment.
Can you use the Low Level Design for the work please?
https://github.com/DEFRA/epr-backend/blob/main/docs/architecture/defined/2025-reg-acc-lld.md#technical-approach
…tup-stubs-organisation-registration-accreditation
There was a problem hiding this comment.
I think we've still got quite a bit to do by considering this PR holistically against the LLD, I think it needs more attention in the detail.
To avoid repetition, I won't repeat feedback across each endpoint, but every comment does need to be considered for each endpoint/test across the entire PR
| name: 'Sarah Lee', | ||
| email: '[email protected]' | ||
| } | ||
| } |
There was a problem hiding this comment.
Shouldn't the payloads look more like DXT form data? Same for all endpoint tests
There was a problem hiding this comment.
we dont know what the forms contain, I think this will take time when the payload actually doesn't matter at this point and will only matter to the database not setting up the endpoint and giving back a response
There was a problem hiding this comment.
We definitely know what the forms contain, we have links to the publicly accessible forms. We also know what data structure DXT sends to the api on submission. I'm suggesting that we make this data a closer representation to the DXT structure (as you've done in the postman collection) as it'll help with testing and future work, rather than doing a quick job now and having to update it later.
| @@ -4,7 +4,8 @@ export const LOGGING_EVENT_CATEGORIES = { | |||
| HTTP: 'http', | |||
| PROXY: 'proxy', | |||
| SECRET: 'secret', | |||
| SERVER: 'server' | |||
| SERVER: 'server', | |||
There was a problem hiding this comment.
it is being used on Start server, i dont understand how its dead code
There was a problem hiding this comment.
Sorry, my mistake. What's the difference between server and api then?
There was a problem hiding this comment.
I guess server is related to server as it is starting or failing, but API would be related to methods relating to our api endpoints. Happy to get a different opinion what the category for the event would be
…tup-stubs-organisation-registration-accreditation
|
Ticket: PAE-159
Description
created stubs for signup, registration, accreditation
Please see the Pull Requests standards.