Skip to content

Fix relations drawn on non existent notes#380

Closed
Crowerade wants to merge 6 commits into
developfrom
fix-relations-drawn-on-non-existent-notes
Closed

Fix relations drawn on non existent notes#380
Crowerade wants to merge 6 commits into
developfrom
fix-relations-drawn-on-non-existent-notes

Conversation

@Crowerade

Copy link
Copy Markdown
Collaborator

Addresses #379

@Crowerade
Crowerade requested a review from yrammos August 13, 2025 13:36
@Crowerade Crowerade self-assigned this Aug 13, 2025
@Crowerade Crowerade added the bug Something isn't working label Aug 13, 2025
@Crowerade
Crowerade changed the base branch from master to develop August 13, 2025 13:37
@yrammos

yrammos commented Aug 13, 2025

Copy link
Copy Markdown
Member

@Crowerade I'm afraid that even after a580a98 and a4f9eab (i.e. the last two commits), creating a meta-relation with relations that are reduced out in other layers still causes a crash. I tested with minimal_analysis_2.mei.

@Crowerade

Copy link
Copy Markdown
Collaborator Author

I tried reproducing it, but it worked fine. Could you tell what steps you followed to have the crash?

@yrammos

yrammos commented Aug 14, 2025

Copy link
Copy Markdown
Member

@Crowerade to reproduce, perhaps you need to create a meta-relation with two relations, only one of which has been reduced-out in the second layer. The other relation in this test existed in both layers.

(I repeated the test again just now to be sure.)

@Crowerade

Copy link
Copy Markdown
Collaborator Author

That's curious, it does not emit any error

@yrammos

yrammos commented Aug 14, 2025

Copy link
Copy Markdown
Member

@Crowerade I sent you a screencap via Mattermost reproducing the bug.

@Crowerade

Copy link
Copy Markdown
Collaborator Author

This should be fixed

@yrammos

yrammos commented Aug 14, 2025

Copy link
Copy Markdown
Member

@Crowerade this is good, thanks.

Unfortunately our predicament with layers continue: un-reducing the added layer (thus adding back the previously removed notes) fails to show the new relations and meta-relations that involved them.

Sent you a video on Mattermost to clarify.

@yrammos

yrammos commented Aug 14, 2025

Copy link
Copy Markdown
Member

Essentially, whenever we un-reduce, after putting back all relevant notes we should have a second step to add any graph (meta-)relations that became renderable.

@Crowerade

Copy link
Copy Markdown
Collaborator Author

I'll look into that

@yrammos
yrammos removed their request for review August 14, 2025 13:46
@Crowerade

Copy link
Copy Markdown
Collaborator Author

This is not planned in the end since we want to have static layers instead of dynamic and updatable ones

@Crowerade Crowerade closed this Aug 15, 2025
@yrammos yrammos added the wontfix This will not be worked on label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working wontfix This will not be worked on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Relations are drawn on all layers, regardless of the existence of the participating notes

2 participants