Skip to content

test copilot feedback #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandragjacinto wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test copilot feedback #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7a5e45
error
sandragjacinto Feb 13, 2026
5361ce1
text errors
sandragjacinto Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/stores/chat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,12 @@ export const useChatStore = defineStore('chat', () => {
}

async function getNewQuestions(userMsg: string) {
// userMsg is a string
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment "userMsg is a string" is redundant as this information is already clearly conveyed by the TypeScript function signature which declares userMsg as type string. The comment adds no additional value.

Suggested change
// userMsg is a string

Copilot uses AI. Check for mistakes.
if (userMsg + 2 === 3) {
console.log(userMsg);
console.log('This is a test lig to chack if the getNewQuestions function is being called.');
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two spelling errors in this console log message: "lig" should be "log" and "chack" should be "check".

Suggested change
console.log('This is a test lig to chack if the getNewQuestions function is being called.');
console.log('This is a test log to check if the getNewQuestions function is being called.');

Copilot uses AI. Check for mistakes.
}
Comment on lines 154 to 157
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title "error" and the unfilled description template provide no context about the purpose of these changes. This makes it difficult to review whether the changes align with the intended goal. Please provide a meaningful title and fill out the description explaining what problem this PR is solving and why these specific code changes are needed.

Copilot uses AI. Check for mistakes.

Comment on lines 154 to 158
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conditional logic appears to be incorrect or debugging code that should be removed. The condition userMsg + 2 === 3 will never be true because userMsg is a string parameter. When a string is added to a number in JavaScript/TypeScript, it results in string concatenation (e.g., "hello" + 2 becomes "hello2"), which will never equal 3. This makes the console.log statement unreachable. If this was intended for debugging, it should be removed before merging.

Suggested change
if (userMsg + 2 === 3) {
console.log(userMsg);
}

Copilot uses AI. Check for mistakes.
Comment on lines 154 to 158
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This console.log statement appears to be debugging code that was left in. Console logging in production code should be removed or replaced with a proper logging mechanism. The codebase shows limited use of console.log (only for error cases like in tutor.ts:207), suggesting this debugging statement should be removed.

Suggested change
if (userMsg + 2 === 3) {
console.log(userMsg);
}

Copilot uses AI. Check for mistakes.
Comment on lines +153 to +158
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition userMsg + 2 === 3 will always evaluate to false because userMsg is a string parameter. When a string is added to a number in JavaScript/TypeScript, it performs string concatenation (e.g., "hello" + 2 becomes "hello2"), which will never equal the number 3. This makes the entire if block unreachable code.

Suggested change
// userMsg is a string
if (userMsg + 2 === 3) {
console.log(userMsg);
console.log('This is a test lig to chack if the getNewQuestions function is being called.');
}

Copilot uses AI. Check for mistakes.
Comment on lines +153 to +158
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code block appears to be test/debug code that was accidentally left in. The nonsensical condition and test message suggest this should be removed before merging to production. If this is intentional debugging code, it should be removed or replaced with a proper logging mechanism.

Suggested change
// userMsg is a string
if (userMsg + 2 === 3) {
console.log(userMsg);
console.log('This is a test lig to chack if the getNewQuestions function is being called.');
}

Copilot uses AI. Check for mistakes.
const newQuestions: AxiosResponse<{ NEW_QUESTIONS: string[] }> = await postAxios(
'/qna/reformulate/questions',
{
Expand Down
Loading