Fix mesh invisible when GPU Instancing and Vertex Deformation are both enabled - #184
Merged
Conversation
shigehiro-yoshiki-ab
approved these changes
Apr 6, 2026
shigehiro-yoshiki-ab
left a comment
There was a problem hiding this comment.
コードベースですがみました!
対応ほぼ同じなので大丈夫だと思います!
sakumanaoki
marked this pull request as ready for review
April 6, 2026 05:41
CA-Tatami
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_VERTEX_DEFORMATION_ENABLED(shader_feature_local_vertex)が Varyings構造体レイアウトに影響し、頂点・フラグメント間で不一致が発生していた
normalOSにアクセスできなくなる副作用も合わせて修正原因
_VERTEX_DEFORMATION_ENABLEDはshader_feature_local_vertex(頂点ステージ限定キーワード)だが、FRAGMENT_USE_NORMAL_WS(両ステージ共通の構造体フラグ)の条件に含まれていた。
normalWS : TEXCOORD7が Varyings に存在normalWSが Varyings に不在関連PR
#171
挙動確認
DepthNormalPassで頂点変形が効くこと
確認したこと