Fix Transparency Rim using rim value already modified by TintColor Rim - #183
Merged
Conversation
CANakanoYui
approved these changes
Apr 3, 2026
sakumanaoki
marked this pull request as ready for review
April 3, 2026 05:00
CA-Tatami
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
TintColor RimとTransparency Rimが同一の
rim変数を共有しており、TintColorRimのGetRimValue(smoothstep)で変換された値がTransparency Rimにそのまま渡されていました。詳細
前提として、
TintColorの Mode がRimTransparencyのRimが有効の2つが併用されている必要があります。
以下でRimlightを計算しているのですが、
NovaShader/Assets/Nova/Runtime/Core/Shaders/ParticlesUberUnlit.hlsl
Lines 386 to 388 in 848eebd
rim変数を使いまわしている関係でNovaShader/Assets/Nova/Runtime/Core/Shaders/ParticlesUberUnlit.hlsl
Lines 489 to 494 in 848eebd
以下にも影響してしまっています。
NovaShader/Assets/Nova/Runtime/Core/Shaders/ParticlesUberUnlit.hlsl
Lines 534 to 539 in 848eebd
修正方針
TintColor Rimで
rim変数を上書きしていた箇所を、tintRimローカル変数に格納するように変更しました。挙動確認
対応前
TintColor の
Sharpnessを変更すると透過領域も変化してしまっています。Before.mov
対応後
TintColor の
Sharpnessを変更しても、透過領域が変化しません。After.mov
確認したこと