fix: resolve members declared in parent interfaces - #827
Merged
Conversation
romm
force-pushed
the
fix/interface-extending-interface
branch
from
July 28, 2026 19:23
606561a to
1719189
Compare
Mapping to an interface crashed as soon as one of its members was declared in a parent interface, because the parent type resolver assumed single class inheritance: `ReflectionClass::getParentClass()` returns `false` for an interface, leading to an assertion error or a `TypeError` further down. The resolver now handles interfaces separately, finding the direct parent interface that declares the member before resolving its type, including its generics when an `@extends` tag is present.
romm
force-pushed
the
fix/interface-extending-interface
branch
from
July 28, 2026 19:32
1719189 to
a3c139d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mapping to an interface crashed as soon as one of its members was declared in a parent interface, because the parent type resolver assumed single class inheritance:
ReflectionClass::getParentClass()returnsfalsefor an interface, leading to an assertion error or aTypeErrorfurther down.The resolver now handles interfaces separately, finding the direct parent interface that declares the member before resolving its type, including its generics when an
@extendstag is present.Fixes #822