Skip to content

Some work towards block matrix assembly with a very basic but still v… - #335

Merged
cmhamel merged 3 commits into
mainfrom
cooks-membrane
Aug 9, 2026
Merged

Some work towards block matrix assembly with a very basic but still v…#335
cmhamel merged 3 commits into
mainfrom
cooks-membrane

Conversation

@cmhamel

@cmhamel cmhamel commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

…ery very very slow cook's membrane example.

Some correctness was looked at such as the matrix K_up \approx K_pu' at both the element and global level.

Need to do a lot of work for speed ups.

@codecov

codecov Bot commented Aug 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 6.73077% with 194 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.03%. Comparing base (0134255) to head (f6de3ab).

Files with missing lines Patch % Lines
src/assemblers/BlockMatrixAssemblers.jl 0.00% 164 Missing ⚠️
src/Parameters.jl 12.50% 21 Missing ⚠️
src/Solvers.jl 0.00% 5 Missing ⚠️
src/assemblers/Assemblers.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   71.14%   69.03%   -2.11%     
==========================================
  Files          54       55       +1     
  Lines        6324     6521     +197     
==========================================
+ Hits         4499     4502       +3     
- Misses       1825     2019     +194     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

cmhamel added 2 commits August 8, 2026 19:55
… in terms of row major vs. column order. Before we were doing things row major on setup then in assemble_element it was column major.
@cmhamel
cmhamel merged commit b36c932 into main Aug 9, 2026
9 of 13 checks passed
@cmhamel
cmhamel deleted the cooks-membrane branch August 9, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant