Scrypt call is executed in background

[abenmrad]

Hi. Thanks for the work put on this module!

I would like to suggest the following modifications hereby attached:

• scrypt call on iOS is ran in a background thread, like it's already the case on Android
• more verifications of the provided parameters in JavaScript

[ggozad]

Ops, sorry for the delay and thanks for your contribution. Will review asap!

[ggozad]

Hey,
I tried to run the tests, and they fail. Could you please have a look and let me know?

[abenmrad]

I tested it from a script I wrote inside the app I'm working on, using some of the vectors in your test script. I'm gonna try yours.

What are you using to run your test script? I sense JasmineJS. Is there anything else? RequireJS?

[ggozad]

The tests are contained in the plugin!
You basically create a cordova app, and add the cordova-plugin-test-framework which is the standard way of writing tests for cordova. See https://github.com/apache/cordova-plugin-test-framework for instructions.

I imagine it will be something minor, but would appreciate it if you find it and fix it, it's a good opportunity to learn the test framework too :)
While we are at it, add your name and update the Changelog!

[ggozad]

I updated the README, with specific instructions on how you can test. Please try it and let me know.

[abenmrad]

Hi. Sorry for the late reply. And thanks for putting together the testing instructions, it helped me out and gained me time :)

I tried it out. And indeed it doesn't give the same results. It's quite intriguing. Some vectors are passing and others are not. So yeah, obviously my pull request shouldn't be merged until we figure out (and fix) what's going wrong... Thanks for pointing this out.

[ggozad]

No problem, I will be happy to merge once you resolve these problems.