Throttle pgbackrest metrics collection frequency - #4536
Open
bendilley wants to merge 2 commits into
Open
Conversation
For Open Telemetry, implement a similar throttling technique to the legacy exporter. Fixes CrunchyData#4532
How to set it in a cluster spec:
```yaml
spec:
instrumentation:
metrics:
pgBackRestInfoThrottleMinutes: 30
```
If omitted, behavior remains equivalent to legacy default throttle
(10 minutes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
As documented in #4532, Open Telemetry monitoring of a pgbackrest S3 store generates steep egress fees. I think the default should have a low impact on egress, and it seems the legacy exporter did implement a throttle for this reason.
What is the new behavior (if this is a feature change)?
For Open Telemetry, implement a similar throttling technique to the legacy exporter, with the same default (10 minutes). The 2nd commit includes a configuration option.
Fixes #4532
Other Information:
I'm not a Go/PGSQL developer so I've used github copilot to vibe-code this change. I hope it helps. Please let me know if there are further changes I can make.