-
Notifications
You must be signed in to change notification settings - Fork 23
Update to 2025.9.9 #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The game uses the tail end of byte values as hard coded values for certain events. Mainly for meetings where the values 252 to 255 are in use (abstain, dead vote, no vote and one more that I can't recall off the top of my head) and town of us uses 251 for meeting roles like Prosecutor. I would recommend setting the max to 250 to avoid this kind of overlap. For example, voting the 255th player to be ejected will likely not work because 255 is registered as the default vote (aka not voted). Now i could be wrong as of the latest update but it's better to be safe than sorry. |
|
If you actually want to have such big lobbies then you should set the max to 250, but if you just want to have a cool number (like I was doing for 6 months) then I suggest keeping it as 255. |
|
"Cool number" is not a valid thing to sacrifice stability over 💀 Who knows? Maybe a big youtuber might wanna make a 200+ player lobby for the hell of it. You wanna keep the mod open for such possibilities |
|
then as I said, if you expect such big number of people then don't make a 255 player lobby. |
|
plus, if you're already talking about stability like I've already said, the mod has been tested for a long period of time with every lobby i've hosted being at 255 people, and nothing broke, and everything worked as expected. |
|
Silent bugs exist but you know what, you do you. Galster will be the one to go through your changes in the end anyways. |
Diffs: