Fix sync-pnpm when already synced previously

[simonihmig]

The sync script would skip syncing the dist folder when it already exists. This is not good when running things locally, like when you run the test-app, and build the addon in watch mode, you would still need to run the sync script after changes in the addon manually. But without this fix here, it would not update the dist output with the addon changes.

Currently my development workflow with this is:

• pnpm start (runs test-app)
• in another terminal:
  • cd <addon-dir>
  • pnpm start (rollup in watch mode)
• in yet another terminal:
  • cd test-app
  • on every change of the addon run manually: pnpm _syncPnpm

Far from good, but at least works...

[changeset-bot]

⚠️ No Changeset found

Latest commit: 64b0216

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

Preview URLs

Env: preview
Docs: https://a7941215.ember-headless-form.pages.dev

[nicolechung]

Suggestion (maybe I should file an issue for this): Can we change the port of either the docs-app or the test-app so I can run both at the same time?

[nicolechung]

on every change of the addon run manually: pnpm _syncPnpm

Wait...what is the difference between running pnpm i -f and pnpm_syncPnpm between each build of the package?

[ynotdraw]

Nice! I also found success with using pnpm link, but not sure if it's any better DX wise. Here's what I found with ember-toucan-core:

# add-on
cd ember-toucan-core
pnpm link .

# go to docs-app now and link it
cd ../docs-app
pnpm link @crowdstrike/ember-toucan-core

Now build the add-on in watch mode

cd ember-toucan-core
pnpm start

Then in another terminal, start the docs app:

cd docs-app
pnpm start

Now if you make a change in ember-toucan-core, it auto-rebuilds and the updates are shown in the docs-app!

---

FWIW, I just tried this in a super small example, not with actually building anything real, so there may still be issues with link

[nicolechung]

I know that I should know this given I reviewed the earlier version, but how do I run syncPnpm

Attached is an image of what I have tried

[nicolechung]

I know that I should know this given I reviewed the earlier version, but how do I run syncPnpm

Attached is an image of what I have tried

NVM Tony just showed me its in the app directory...

[simonihmig]

NVM Tony just showed me its in the app directory...

Yeah, it's only available to apps. Ideally we shouldn't call this ourselves of course (hence the underscored name), but we are still figuring things out. Seems @NullVoxPopuli is also up for something:

• Setup turborepo, with injected dependency syncing ember-headless-table#145
• feat(cli): add sync command for working with external projects pnpm/pnpm#6135

[nicolechung]

Okay now that I figured out how to get this running...this is definitely an improvement!

I only have to run the command pnpm _synchPnpm once and it works!