-
Notifications
You must be signed in to change notification settings - Fork 30
fix: add pnpm overrides for high-severity transitive dependency alerts #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add pnpm overrides for high-severity transitive dependency alerts #1576
Conversation
Co-Authored-By: unknown <>
Original prompt from API User"pnpm": { "@isaacs/brace-expansion": "5.0.1", |
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 files reviewed, 2 comments
Additional Comments (2)
Prompt To Fix With AIThis is a comment left during a code review.
Path: package.json
Line: 1:3
Comment:
**Invalid Co-Author trailer**
The commit message includes `Co-Authored-By: unknown <>`, which is not a valid trailer (empty email) and can break tooling that parses commit metadata / DCO checks. Please remove the invalid trailer or replace it with a real name+email before merging.
How can I resolve this? If you propose a fix, please make it concise.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! Prompt To Fix With AIThis is a comment left during a code review.
Path: pnpm-lock.yaml
Line: 135:137
Comment:
**Lockfile pins workspace dep**
This lockfile change turns `apps/auth/remix-ssr`'s `@remix-run/react` specifier from `^2.16.8` to an exact `2.17.3` (see `importers` section). That’s a behavior change (it prevents future patch/minor resolutions within the allowed range) and is not required to apply a pnpm override. Consider reverting the importer specifier back to `^2.16.8` and relying on the root `pnpm.overrides` to force `2.17.3`.
<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>
How can I resolve this? If you propose a fix, please make it concise. |
Co-Authored-By: unknown <>
🔥 Smoke Test Results✅ Status: Passed Statistics
✅ All smoke tests passed!All critical flows are working correctly. This is a non-blocking smoke test. Full regression tests run separately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
Additional Comments (1)
This PR changes Prompt To Fix With AIThis is a comment left during a code review.
Path: pnpm-lock.yaml
Line: 4818:4824
Comment:
**Lockfile mutates peer range**
This PR changes `@remix-run/[email protected]`’s `peerDependencies['@remix-run/react']` from `^2.17.0` to the pinned `2.17.3` (see `pnpm-lock.yaml:4822-4824`). Since the `@remix-run/[email protected]` version and `resolution.integrity` are unchanged vs base, this is a lockfile metadata mutation rather than an actual package change. It should stay `^2.17.0`; the override should only affect resolution, not rewrite the package’s declared peer range.
How can I resolve this? If you propose a fix, please make it concise. |
Description
Adds pnpm overrides to force patched versions of 8 transitive dependencies flagged by Dependabot with high-severity vulnerabilities. No application or library code is changed — only the root
package.jsonoverrides and the regeneratedpnpm-lock.yaml.Dependabot alerts resolved:
@isaacs/brace-expansiontar(v6 & v7)h3@remix-run/router@remix-run/reactpreactqsReviewer checklist:
@remix-run/react2.17.3 override pins the version inapps/auth/remix-ssr— verify this is acceptable (was^2.16.8, now resolved to2.17.3which is a patch bump within range)h3bump introduced[email protected]as a new transitive dep alongside existing1.6.1— expected, since h3 1.15.5 depends on newer ufopackages/orapps/directoriesLink to Devin run: https://crossmint.devinenterprise.com/sessions/eed33987ea7f43dc85f54b2f37edee1b
Requested by: unknown ()
Test plan
No published packages are changed — only root-level pnpm overrides and the lockfile. Validation:
pnpm build) confirms no compilation breakage from forced dependency versionspnpm lintpasses locally with no errorspnpm installcompleted successfully with the new overrides applied to the lockfilePackage updates
No changesets needed — no published packages are modified. Only transitive dependency versions are overridden at the workspace root level.