Fix #9334: belt funnel not blocking items when inserting to a full vault#9891
Open
Apertyotis wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Open
Fix #9334: belt funnel not blocking items when inserting to a full vault#9891Apertyotis wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Apertyotis wants to merge 1 commit intoCreators-of-Create:mc1.21.1/devfrom
Conversation
Author
|
fix #9334, though it is still unclear why RPM affects this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #7400
fix #9334 (duplicate issue)
Bug Description
Belt funnels facing against belt movement fail to block items when the target vault is already full.
Fix
When the vault is full,
stillWaiting()returns true, indicating that items cannot be inserted. In this case,blockingshould be checked, andcheckForFunnels()should return true when blocked, indicating that the item is obstructed.